SteveSanderson / knockout-es5

Knockout.js meets ECMAScript 5 properties
158 stars 39 forks source link

Add latest to NPM? #41

Closed grofit closed 8 years ago

grofit commented 9 years ago

Any chance we could get the latest version of this added to NPM, the latest on there is 0.1.1.

archangel-irk commented 9 years ago

I can't do it. Since I have no access to npm account. I hope that @SteveSanderson will help us.

atom-project commented 9 years ago

+1

mmacaula commented 8 years ago

+1

archangel-irk commented 8 years ago

I contacted the owner of the npm repo and asked to update the version of the library

grofit commented 8 years ago

one other thing worth mentioning is that currently there is an issue where ideally this lib should be using peerDependencies to satisfy the knockout dependency as shown here;

https://github.com/Knockout-Contrib/Knockout-Validation/issues/602

I have changed it in a fork and can submit a pull request if you want, but its a 1 line change.

archangel-irk commented 8 years ago

Thanks, its done.