search

SteveSandersonMS / WebWindow

.NET Core library to open native OS windows containing web UI on Windows, Mac, and Linux. Experimental.
Apache License 2.0
1.98k stars 215 forks source link

Implemented Dispose #18

Open ajmcateer opened 4 years ago

ajmcateer commented 4 years ago

I implemented dispose in the WebWindow but I am having trouble getting it to work in Windows. Linux was a complete shot in the dark as I have never worked with C++ let alone on Linux before. I get

Exception thrown: 'System.EntryPointNotFoundException' in WebWindow.dll

whenever I try to call the dispose method. As far as I can tell I implemented everything correctly, but I am knew to C++ so its very likely I missed something. Any feedback would be greatly appreciated. I also didn't see a WebWindow.Mac.cpp file to make changes too.

Berrysoft commented 4 years ago

I also didn't see a WebWindow.Mac.cpp file to make changes too.

It's WebWindow.Mac.mm.

SteveSandersonMS commented 4 years ago

@ajmcateer Thanks for contributing this!

Do you think you'll be in a position to finish this PR off? That would involve figuring out the solution to whatever issue you're describing, as well as tidy this up to remove the unnecessary changes (e.g., in WebWindow.Native.vcxproj).

If that's not something you'll get round to, no problem - I may add some functionality like this myself eventually, though there's no ETA.