Add some properties for WebWindow.

[Berrysoft]

Working items

• [x] Clean up code.
• [x] Size, Width, Height
• [x] Location, Left, Top
• [x] Topmost
• [x] Icon from file
• [x] Screen size & DPI
• [x] Maximizable & Minimizable Resizable
• [x] Resize & move event
• [x] Register WebWindow singleton
• [x] Update SDK for Edge

Related issues

35

39

[Berrysoft]

@SteveSandersonMS Using auto charset I could remove the multi-byte<=>wide-char string convert methods, and reduce some allocations. I think it belongs to the cleanup, which is my first working item. Please tell me if you want a separate pull request.

[SteveSandersonMS]

This is looking great! Thanks for working on this.

I’m fine with charset cleanup either being in the same PR or a different one.

[Berrysoft]

@SteveSandersonMS I've added the features planned above. However, I don't have a Mac with me now. Could you help me test it? The test page has been added to testassets/MyBlazorApp.

Also there's a remaining issue I haven't figure out the reason: if you call StateHasChanged in the handler of SizeChanged or LocationChanged, the window will block. The work around is to wrap StateHasChanged in Task.Run(...).

[Berrysoft]

My Edge Dev updated automatically and it deprecated an API the project uses. I had to use newer API to test it.

[SteveSandersonMS]

This is looking great, @Berrysoft! If you could let me know when you consider this done and ready to merge, I'll be happy to proceed with it.

[Berrysoft]

@SteveSandersonMS I consider it done now. I will keep investigating better work around for the thread problem, but I don't think it is easy to solve at once.

[Berrysoft]

ping @SteveSandersonMS

[SteveSandersonMS]

Thanks, will take a look!

[SteveSandersonMS]

Thanks again @Berrysoft for this! It's looking great!

I've tried it out and encountered a few issues on macOS:

• In the MyBlazorApp app, the "Window size" and "Window location" values don't update when you drag the window around
  • Also the "Window location" values show as negative numbers, though maybe that aspect of it isn't a problem
• Also in this app, trying to modify the "Window size" or "Window position" values (e.g., by clicking the "up" arrow next to the widths or heights) causes strange behavior:
  • The window's left-hand edge moves to the right when the window width is increased, and its bottom moves upwards when the window height is increased. It seems like some size/position calculations are not being done quite correctly.
  • When changing size or position by editing the text boxes, the console output produces the message NSWindow drag regions should only be invalidated on the Main Thread! This will throw an exception in the future (see below for full stack trace)

I've added some fixes for this which I will include when merging this PR.

[SteveSandersonMS]

Merged. Thanks again @Berrysoft!

[Berrysoft]

That's OK, and thank you for your help and fixes!