search

SteveTownsend / ImmersiveEquipmentMeshGen

Skyrim SE Synthesis Patcher for Immersive Equipment Display - mesh generation
GNU General Public License v3.0
13 stars 12 forks source link

Ensure scabbard child nodes have unique names #8

Closed SlavicPotato closed 2 years ago

SlavicPotato commented 2 years ago

I've noticed some (custom) weapons have scabbards with child nodes named after the parent which can cause nifskope clobbering 'ScbLeft' during sanitization on save.

SteveTownsend commented 2 years ago

Is action needed for the patcher? Sounds like the meshes are not correct. I think it's standard to use Scb for the scabbard name?

In any case, that's a good reason for us not to optimize/sort on save.

On Thu, Mar 10, 2022 at 9:49 AM SlavicPotato @.***> wrote:

I've noticed some (custom) weapons have scabbards with child nodes named after the parent which can cause nifskope clobbering 'ScbLeft' during sanitization on save.

You can view, comment on, or merge this pull request online at:

https://github.com/SteveTownsend/ImmersiveEquipmentMeshGen/pull/8 Commit Summary

File Changes

(1 file https://github.com/SteveTownsend/ImmersiveEquipmentMeshGen/pull/8/files)

Patch Links:

- https://github.com/SteveTownsend/ImmersiveEquipmentMeshGen/pull/8.patch

https://github.com/SteveTownsend/ImmersiveEquipmentMeshGen/pull/8.diff

— Reply to this email directly, view it on GitHub https://github.com/SteveTownsend/ImmersiveEquipmentMeshGen/pull/8, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRDNC4S3GZDVDLVGFEKMFLU7IDVXANCNFSM5QM3PTKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

SlavicPotato commented 2 years ago

Yeah this is basically incorrect, nifskope fixes it on save and doesn't seem to ever rename 'Scb' nodes (probably recognizes that it shouldn't) but the children instead. This isn't the case for our 'ScbLeft' nodes though, these may get renamed so the action is indeed needed. Each node in the tree should have an unique name anyway. Just to be clear: this change only applies to ScbLeft nodes.

SteveTownsend commented 2 years ago

I'm so sorry, I did not realize this was a new PR with a fix, and not comments on the closed one. Should be able to build this tonight or tomorrow.

SlavicPotato commented 2 years ago

No worries!