SteveTownsend / SmartHarvestSE

AutoHarvest 2 Skyrim SE mod ported to CommonLibSSE
GNU General Public License v3.0
18 stars 7 forks source link

Possible glitch or incompatibility in ingredient looting #405

Open SteveTownsend opened 1 year ago

SteveTownsend commented 1 year ago

Nexus bug report from GhostWalker71 https://www.nexusmods.com/skyrimspecialedition/users/130572

I found a few items that behave like the bleeding crown. So it appears the bleeding crown is processed correctly until it reaches the per item limit. After the limit is reached, even if the item count in inventory drops below that limit again, they will no longer be collected. This only appears to reset by exiting and restarting skyrim.

as to the flowers I was referring to it was the MountainFlower01Blue MountainFlower01Purple MountainFlower01Red Though I suspect I only noticed it with the mountain flowers because it is so easy to gather so many in a small area. It is possibly a interaction with my mod logic random loot which changes the amount of items collected from flora and fauna and the frequency of the script in your mod that checks the per item amount in inventory. I still need to do more testing for this though.

Ghostwalker71 commented 1 year ago

I was doing more testing/playing last night and went into arkanthamz(sp) the dwemer dungeon where you take the lexicon. anyway I moved into a room with several dwemer ingots sitting on a table and shelf. the auto harvest picked up 3 out of the 5 on the table and 2 of the 7 on the shelf and would not collect any of the rest for some reason. I'm also noticing rather weird behavior similar to this with other random items. By random I mean on one loading of the game the auto harvest will suddenly ignore all steel arrows but on a subsequent play session the arrows are handled fine. at first I thought it was script load issue but my papyrus logs are not reflecting this. I'm going to start a fresh game with only "the basics" and smartharvest and see if I can replicate these issues. You wouldn't happen to have a test world esp with a bunch of random items and plants already set up would you?

SteveTownsend commented 1 year ago

I don't - my own game is a WIP after HDD failure this summer

Ghostwalker71 commented 1 year ago

ok more testing complete, I've been running all over skyrim with a script latency scanning tool running, My system never went over 100ms at any point except when I was in menu mode which is expected. I approached several different clusters of items and saw that smart harvest would gather some of each type of item and then stop processing that item. In once instance there was approx. 10 silver goblet 15 red apple and 10 green apple some carrots and leeks, smart harvest picked up about half of each group then stopped and would not continue until I moved about 25 feet away then moved back. This happens with all types of items. in one instance I took out a group of bandits that all happened to be wearing the same armor. they were all within a few feet when the combat ended and smart harvest collected the armor from 2 of the 5 bandits and completely ignored the steel arrows. It appears my guess about the interaction between my harvest loot mod and smart harvest was correct. The reason I was able to gather so many of the mountain flowers was due to the fact that each bush can drop up to 20 flowers so walking into a cluster allowed smart harvest to over collect. Not sure if it would be worth the extra script load to have it check the per item count more often. I'm not sure I can do much more than this, I would need some way to monitor variables more accurately to be of any further help. but I'll be happy to do more testing on the next build and report my finds, or if you think I can do more on this build let me know what you need checked.

Ghostwalker71 commented 1 year ago

Just a small update, I've been trying and failing to get a handle on what is going wrong with this mod and my best guess at this point is variable shadowing but I haven't been able to sit down and read your scripts enough to really understand them. From what I am seeing, I change one selection in the menu(meaning change the body loot option from loot all except armor to loot all) and suddenly items that were being processed correctly are now collecting way over the limit and if I change the variable for that item from leave excess to convert to septims, the item may or may not process the extra items and as often as not another one of the ingredients will randomly change to either start processing as expected or start over collecting. I've tested this in a game with only the mods absolutely required for your mod to function as well as a game that is fully modded and it behaves the same in both instances. I've even been considering a complete reinstall of Skyrim to see if perhaps there is some hidden files that were left over from a past mod list. I hope this will perhaps point you in the general direction of figuring things out.

SteveTownsend commented 9 months ago

I finally twigged that this relates to user's own mod adjusting drop counts. Review. https://www.nexusmods.com/skyrim/mods/43245?tab=description