SteveTownsend / SmartHarvestSE

AutoHarvest 2 Skyrim SE mod ported to CommonLibSSE
GNU General Public License v3.0
18 stars 7 forks source link

Soulgem trap harvest loop #412

Open SteveTownsend opened 1 year ago

SteveTownsend commented 1 year ago

Nexus report from blackjackgarry

I was going through Brittleshin Pass, coming from the lakeside. There you have this common soul gem stand which is firing at you. I was shooting the soul game down, and in the falling I crossed the treshold (the auto collection radius) and the auto harvest started. And now I harvest the common soul gem again-and-again. Its not taken from the floor where its now lying, but the harvest always shows a message that its harvesting it - and the soul gem count in my inventory rises. It repeads itself without ending.

I let it run, and after ~1hour RL I now have ~7000+ common soul gems (filled!) - NICE :-) :-) Well, easy way to push up enchantment skill and make money...

When I leave the harvest radius or the area (Brittleshin Pass), it stops. Coming back it starts again. Well, maybe after a reset of the worldcell after 30days it may be gone, will see...

I couldn't reproduce it again. I loaded an earlier save, tried to shoot the soul gem and harvest it, but could never redo it again. I then used cmd markfordelete and with that the soul gem is gone, and the cycle stopped /...only afterr I let it run some time...)

My reply

The handling for those trapped soulgem activators just hooks into the script state, it does not edit it at all. https://github.com/SteveTownsend/SmartHarvestSE/blob/4f9406a677a19bf45a01e1211efc5c942021e66b/Scripts/SHSE_EventsAlias.psc#L1214 Perhaps there is a missing safety check here to prevent consecutive harvest attempts if for some reason the now-inert soul gem does not get cleaned up. I'll add this to the list.

SteveTownsend commented 1 year ago

Another report from https://www.nexusmods.com/skyrimspecialedition/users/10903443

There is a soul gem there that keeps the barrier up. Smart Harvest will take that gem before the barrier comes down and then the barrier never comes down. I get around this by pausing harvesting before entering the temple. Then I turn it back on after the barrier is down and then clean out the place when the quest is done.