StevenBlack / hosts

πŸ”’ Consolidating and extending hosts files from several well-curated sources. Optionally pick extensions for porn, social media, and other categories.
MIT License
26.88k stars 2.23k forks source link

some Porn hosts i found that should be included in porn Block hosts list. (Link) #1745

Closed brijrajparmar27 closed 3 years ago

brijrajparmar27 commented 3 years ago

here are some porn hosts i extracted by DNS logging that were not being Blocked and i feel should be included in porn hosts.

as per contribution guidelines i put up a repo for the hosts i compiled, the link for the same is https://github.com/brijrajparmar27/AdBlock-Hosts/blob/master/custom-porn-hosts

regards.

welcome[bot] commented 3 years ago

Hello! Thank you for opening your first issue in this repo. It’s people like you who make these host files better!

StevenBlack commented 3 years ago

Thank you for this Brijrajsinh @brijrajparmar27.

The link in your issue description doesn't work. This is the correct link: https://github.com/brijrajparmar27/AdBlock-Hosts/blob/master/custom-porn-hosts.

Here's the breakdown, using ghosts. This would add 98 new domains to our amalgamated code list, with no intersection. So good work!

$ ghosts -m p -c https://raw.githubusercontent.com/brijrajparmar27/AdBlock-Hosts/master/custom-porn-hosts
----------------------------------------
Base hosts file summary:
----------------------------------------
Location: https://raw.githubusercontent.com/StevenBlack/hosts/master/alternates/porn/hosts
Domains: 115,666
Bytes: 3.4 MB
----------------------------------------
----------------------------------------
Compared hosts file summary:
----------------------------------------
Location: https://raw.githubusercontent.com/brijrajparmar27/AdBlock-Hosts/master/custom-porn-hosts
Domains: 98
Bytes: 2.6 kB
----------------------------------------
Intersection: 0 domains

My one concern is, we normally accept source lists with a track record, a long history of curation. From curators who are in this over the long haul. In particular, we aren't into lists that are add-only buckets, and unresponsive to mistakes.

Let me think about it. You've found nearly 100 new porn domains, which is something.

Brijrajsinh If you feel you're going to curate this list into the future, a pull request adding your list to the ./data folder here will help move this along πŸ˜„

brijrajparmar27 commented 3 years ago

Let me think about it.

i did find some additional hosts expanding the 100 ones i mentioned. okay, i think i can keep my list upto date with hosts i find myself.

maybe i can even automate the process to some extent from my side of mining hosts, i just made a fork, lets do this.

do i just name it as hosts under data/(my name)? if so, do i have to make a pull request to my hosts file every time i add new hosts?

or do i make a repository for it and make an entry under update.json and it will fetch hosts from my repo automatically.

lastly, currently my list is only for porn-blocking, what is the convention here? how do you separate/specify porn hosts from ads hosts. or is it done on your end?

StevenBlack commented 3 years ago

Brijrajsinh @brijrajparmar27 that would go in the ./extensions/porn folder. Porn, Gambling, and FakeNews are called extensions in this repo.

brijrajparmar27 commented 3 years ago

got it, and do i make a pull request every time i update the sources?

do i make a repository for it and make an entry under update.json and it will fetch hosts from my repo automatically.

or is it this... how would the updates take place from my end.

StevenBlack commented 3 years ago

Brijrajsinh @brijrajparmar27 our pipeline pulls latest from all sources, as needed.

brijrajparmar27 commented 3 years ago

hello steven,

yesterday i updated my porn hosts with some additional 50 uncovered domains i scraped over the span of a day, making total host in my hosts file 148.

to my attention, the entry under extensions hasn't updated automatically, is it possible that there's any issue from my end?

StevenBlack commented 3 years ago

Hi Brijrajsinh @brijrajparmar27 this repo does not update automatically. It updates after I run our pipeline, then inspect all the diffs, then commit & push to master.

Inspecting the diffs can take awhile. This is a key step because list curators sometimes make mistakes. This happens more often than we might imagine. I'll delay a release if one of the curators needs to amend a recent change.

brijrajparmar27 commented 3 years ago

@StevenBlack hello sir

i didn't know where to approach you so i figured i'd just write here.

i was thinking of compiling a list of malicious apps, apps that are known to exploit user data/permissions or apps that leech data to shady servers, its not the as same as dns hosts but it is under a similar umbrella to some extent.

should i do it? do you see it being of any use to the community?