search

StevenGolovkine / FDApy

Python Package for Functional Data Analysis
https://fdapy.readthedocs.io/en/latest/
MIT License
42 stars 15 forks source link

UFPCA Error #11

Closed Msalehi237 closed 11 months ago

Msalehi237 commented 1 year ago

In the examples for fpca "plot_fpca_1d.py" line 60:

scores = ufpca.transform(data, method='NumInt')

Runs into an error and returns: ValueError: operands could not be broadcast together with shapes (100,1,1) (49,3,101)

StevenGolovkine commented 1 year ago

Hi,

I am well aware of this error. This is due to a re-implementation of the integrate function to generalise to higher dimensional domains. Fixing this error is not as straightforward as I was thinking. If you can fix it, I'll be happy to add your code into the package (function _numerical_integration in UFPCA class).

StevenGolovkine commented 1 year ago

I wrote a quick fix to this error. It should work, but I did not do extensive testing.

StevenGolovkine commented 11 months ago

This has been fixed. I close the issue.