search

StevenLooman / async_upnp_client

Async UPnP Client for Python
Other
46 stars 37 forks source link

No need to handle None values in IGD add_port_mapping/delete_port_mapping #209

Closed StevenLooman closed 1 year ago

StevenLooman commented 1 year ago

No need to handle None values in IGD add_port_mapping/delete_port_mapping, refs #208

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e05dae4) 72.43% compared to head (bc9fb45) 72.43%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #209 +/- ## ============================================ Coverage 72.43% 72.43% ============================================ Files 19 19 Lines 4041 4041 ============================================ Hits 2927 2927 Misses 1114 1114 ``` | [Files](https://app.codecov.io/gh/StevenLooman/async_upnp_client/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Steven+Looman) | Coverage Δ | | |---|---|---| | [async\_upnp\_client/profiles/igd.py](https://app.codecov.io/gh/StevenLooman/async_upnp_client/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Steven+Looman#diff-YXN5bmNfdXBucF9jbGllbnQvcHJvZmlsZXMvaWdkLnB5) | `46.54% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.