search

StevenLooman / async_upnp_client

Async UPnP Client for Python
Other
46 stars 37 forks source link

Added check that album art uri is a valid string #215

Closed darrynlowe closed 10 months ago

darrynlowe commented 11 months ago

Some Samsung TVs return a profile that has an "album_art_uri" property set to None. As-was, this caused a string handling error in the absolute_url call. Fix is to simply check that the uri is not null before the call.

StevenLooman commented 11 months ago

Hi @darrynlowe, thank you for the PR! Can you add a test for this?

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e76d867) 72.42% compared to head (571b139) 72.42%.

Files Patch % Lines
async_upnp_client/profiles/dlna.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #215 +/- ## ============================================ Coverage 72.42% 72.42% ============================================ Files 19 19 Lines 4043 4043 ============================================ Hits 2928 2928 Misses 1115 1115 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

StevenLooman commented 10 months ago

Thanks! Do you want a release with this?

darrynlowe commented 10 months ago

Thanks for merging in. No need for a special release for my sake given you release so frequently already (which is great, btw).

StevenLooman commented 10 months ago

There is a low chance of a change resulting from a home assistant issue. I'll await the results from that issue and create a new release after that.

StevenLooman commented 10 months ago

No activity regarding the home assistant issue. This weekend I'll create 0.38.1 to include this PR.

StevenLooman commented 10 months ago

I've released 0.38.1. I'm unsure if you were experiencing the issue via home assistant, but I'll create a PR there to bump this library.

StevenLooman commented 10 months ago

The release is already in home assistant, see https://www.home-assistant.io/blog/2024/01/03/release-20241/#release-202415---january-20

Hope this fixes the problem with your TV.

darrynlowe commented 10 months ago

Works great - thanks for help!