StevenMaio / rl-repair

Repository for python implementation of thesis work
1 stars 0 forks source link

Change how access to the graph node features is handled #13

Closed StevenMaio closed 1 year ago

StevenMaio commented 1 year ago

Right now, access to the node features is done via the FixPropRepairLearn class. And so all of the classes which need access to the node features need access to FPRL. In order to keep the signatures the same, I added a _fprl field to all of these classes. However, this is horrendous. And so I'd like to change this at some point.

I think there are two approaches to this:

I recommend to my future self to go through the second route.

StevenMaio commented 1 year ago

I submitted a change which handles this