Add default mappings for types. Change visibility to public for mappings to allow compiled ef contexts

StevenRasmussen / EFCore.SqlServer.NodaTime

NodaTime support for EF Core

MIT License

109 stars 18 forks source link

Closed evolvedlight closed 7 months ago

evolvedlight commented 7 months ago

This fixes #39 I tried where possible to match the postgres driver syntax and the recommended MSSQL field names for defaults

StevenRasmussen commented 7 months ago

Thanks for submitting this! Is there a unit test that you could add to verify this functionality?

evolvedlight commented 7 months ago

Sure, will take a look later today

evolvedlight commented 7 months ago

Hey, I added some tests here - it's not 100% possible to verify the compiled mode perfectly but hopefully this matches what is useful

evolvedlight commented 7 months ago

Did you manage to get time to check this? It's currently blocking an upgrade to .Net 8 and I'd prefer to not use my fork. Thanks!

StevenRasmussen commented 7 months ago

Looks good! Thanks!

evolvedlight commented 6 months ago

Thanks, and thanks again for your work on this library! Have a nice week!