Closed budokaiman closed 5 months ago
I question the naming of ownerNameField
and showOwnerName
. The default seems to be showing the team name, but functionally it could be any extra field that is defined.
Maybe it should be more explicit teamNameField
and showTeamName
instead.
I question the naming of
ownerNameField
andshowOwnerName
. The default seems to be showing the team name, but functionally it could be any extra field that is defined.Maybe it should be more explicit
teamNameField
andshowTeamName
instead.
I went back and forth on this, and decided to stick with "owner name field" in case there was ever a time that an owning user should be shown over the owning team. This would reduce the need for extra variables or a subsequent rename. Let me know if you still disagree, I can change the naming
I greatly appreciate this PR and will be happy to accept it once the locale file issue is sorted out.
I greatly appreciate this PR and will be happy to accept it once the locale file issue is sorted out.
Cheers, I greatly appreciate the software you've built, so happy to contribute where able.
Include team battles in "my battles/retros/storyboards". I opted to include team battles in the existing list as I found it the easiest to navigate as well as making logical sense (especially if using retros/storyboards). If a user is added to an existing team, they will be able to see past battles and retros for the team, but they will still be listed under current ones. There are no duplicates or need for condensing results. Team items are indicated by the team name next to the item name.
I had also considered the following before settling on the combined view
Addresses Issue #168