Fix header auth, could not configure AuthHeaderEmailHeader - Githubissues

StevenWeathers / thunderdome-planning-poker

⚡ Thunderdome is an open source agile planning poker, sprint retro, and story mapping tool

https://thunderdome.dev

Apache License 2.0

396 stars 103 forks source link

Fix header auth, could not configure AuthHeaderEmailHeader #554

Closed Kaffeetasse closed 3 months ago

Kaffeetasse commented 3 months ago

Description

This PR fixes the bug regarding the Header Authentication AuthHeaderEmailHeader, as it was not possible to configure a Header name.

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑‍💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents

Screenshots/Recordings

Steps to QA

Configure Header Authentication for example:

AUTH_METHOD: "header"
AUTH_HEADER_USERNAME_HEADER: "x-token-user-name"
AUTH_HEADER_EMAIL_HEADER: "x-token-user-email"

Now a User can login but the E-Mail field will be empty.

StevenWeathers commented 3 months ago

Please run goimports -w . to fix the go formatting so the build lint step will pass.

Kaffeetasse commented 3 months ago

@StevenWeathers sorry I did not think that this will be an issue, should now be fixed.