StevenWeathers / thunderdome-planning-poker

⚡ Thunderdome is an open source agile planning poker, sprint retro, and story mapping tool
https://thunderdome.dev
Apache License 2.0
396 stars 103 forks source link

[Bug]: Empty plans from api #573

Open Jaz7Mutant opened 3 months ago

Jaz7Mutant commented 3 months ago

Description

After migrating from 3.6.0 to 3.12.4 I've got problems with blank info about plans in API: GET https://thunderdome.[mydomen]/api/users/ae832c4c-63f4-4a4b-a6ba-7b64bb14c636/battles?limit=1

{
  "success": true,
  "error": "",
  "data": [
    {
      "id": "<some guid>",
      "name": "23.04.2024",
      "users": [],
      "plans": [
        {
          "id": "",
          "name": "",
          "type": "",
          "referenceId": "",
          "link": "",
          "description": "",
          "acceptanceCriteria": "",
          "priority": 0,
          "points": "",
          "active": false,
          "skipped": false,
          "voteStartTime": "0001-01-01T00:00:00Z",
          "voteEndTime": "0001-01-01T00:00:00Z",
          "position": 0
        },
        {
          "id": "",
          "name": "",
          "type": "",
          "referenceId": "",
          "link": "",
          "description": "",
          "acceptanceCriteria": "",
          "priority": 0,
          "points": "",
          "active": false,
          "skipped": false,
          "voteStartTime": "0001-01-01T00:00:00Z",
          "voteEndTime": "0001-01-01T00:00:00Z",
          "position": 0
        },
        {
          "id": "",
          "name": "",
          "type": "",
          "referenceId": "",
          "link": "",
          "description": "",
          "acceptanceCriteria": "",
          "priority": 0,
          "points": "",
          "active": false,
          "skipped": false,
          "voteStartTime": "0001-01-01T00:00:00Z",
          "voteEndTime": "0001-01-01T00:00:00Z",
          "position": 0
        }
      ],
      "votingLocked": true,
      "activePlanId": "",
      "pointValuesAllowed": [
        "0",
        "1/2",
        "1",
        "2",
        "3",
        "5",
        "∞",
        "😵"
      ],
      "autoFinishVoting": true,
      "leaders": [
        "ae832c4c-63f4-4a4b-a6ba-7b64bb14c636",
        "ae832c4c-63f4-4a4b-a6ba-7b64bb14c636",
        "ae832c4c-63f4-4a4b-a6ba-7b64bb14c636"
      ],
      "pointAverageRounding": "ceil",
      "hideVoterIdentity": false,
      "joinCode": "",
      "teamId": "",
      "teamName": "<myteam>",
      "createdDate": "2024-04-23T12:10:24.758078Z",
      "updatedDate": "2024-04-23T12:10:24.758078Z"
    }
  ],
  "meta": {
    "count": 17,
    "limit": 1,
    "offset": 0
  }
}

Migrating back to 3.6.0 solves that issue, but I can't authenticate. I can provide more info, but I'm not sure what can be helpful.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

StevenWeathers commented 5 days ago

Sorry for the delay I was on leave from working, I will look into this one as soon as possible.

StevenWeathers commented 3 days ago

So this was an optimization to the query performance, is there a reason you need all the stories (previously referred to as plans) details for multiple games at a time? If you just need the stories for a specific game (previously referred to as Battle) you can use the singular API to retrieve those.