StevenWeathers / thunderdome-planning-poker

⚡ Thunderdome is an open source agile planning poker, sprint retro, and story mapping tool
https://thunderdome.dev
Apache License 2.0
421 stars 109 forks source link

fix: SMTP no auth support #638

Closed jdesnoes closed 3 weeks ago

jdesnoes commented 3 weeks ago

Description

This PR updates the go-mail dependency from v0.5.0 to v0.5.1 to fix a bug:

In few words, with go-mail v0.5.0, we can't use the SMTP client without authentification. In my case, my SMTP server doesn't support authentification (I know, it's bad), but the library always check if it does and crash if it doesn't, even when I configure the SMTP client to don't use any kind of authentification (authentification type not set or set to "NOAUTH" for example).

This bug is now solved in the go-mail library so just updating it to the last availavble version (v0.5.1 for the moment) would fix this.

What type of PR is this? (check all applicable)

Related Tickets & Documents

Screenshots/Recordings

Current error logs with no auth method:

"level":"error","ts":1729507900.153856,"caller":"http/team.go:386","msg":"handleTeamInviteUser error","version":"4.17.2","error":"failed to send mail: dial failed: server does not support SMTP AUTH"

Steps to QA

  1. Run a STMP server without authentification
  2. Run the application with the updated library and a configuration set to smtp.auth: "NOAUTH"
  3. Check in the logs that the application doesn't check the authentification method supported by the SMTP server
  4. Check the mail is sent correctly