search

StevensSEC / monocle

A mobile app to transcribe images of printed text from a page.
GNU General Public License v3.0
3 stars 0 forks source link

Suffix `View` is potentially confusing #57

Closed dcarpenter31 closed 2 years ago

dcarpenter31 commented 2 years ago

The View suffix is currently intended for components that take up the entirety of the mobile device screen. However, React Native View components do not necessarily take up the entirety of the screen. This can cause confusion some may be lead to think that a full-size component will only take up some the screen, or that a full-screen component should not get the suffix View.

Let's move all of the View components into a folder called /screens and change the suffix of each component to Screen.

rmonaghanjr commented 2 years ago

I am on board with this, but what if we called the folder /views for consistency?

dcarpenter31 commented 2 years ago

depend on what the suffix is I think. if we choose the suffix View, then yes we should go with /views. otherwise, if we choose the suffix Screen, then we should go with /screens.

rmonaghanjr commented 2 years ago

Right.