search

StevensSEC / pokemonbattlelib

A portable library for accurately simulating Pokemon battles.
GNU General Public License v3.0
12 stars 2 forks source link

fix: linting #275

Closed adapap closed 3 years ago

adapap commented 3 years ago

Some small linting errors that came up. As an aside, the HTTP library may benefit from this change:

Writing a custom http.ResponseWriter to handle things like JSON marshalling, default status codes, and error checking

codecov[bot] commented 3 years ago

Codecov Report

Merging #275 (afc8067) into main (f0e50ec) will increase coverage by 0.2600%. The diff coverage is 100.0000%.

:exclamation: Current head afc8067 differs from pull request most recent head 3b9bc57. Consider uploading reports for the commit 3b9bc57 to get more accurate results Impacted file tree graph

@@               Coverage Diff                @@
##               main       #275        +/-   ##
================================================
+ Coverage   92.9155%   93.1756%   +0.2600%     
================================================
  Files            13         13                
  Lines          1101       1099         -2     
================================================
+ Hits           1023       1024         +1     
+ Misses           71         70         -1     
+ Partials          7          5         -2
Impacted Files Coverage Δ
transactions.go 96.0317% <100.0000%> (+2.2817%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f0e50ec...3b9bc57. Read the comment docs.