Closed adapap closed 3 years ago
Merging #291 (073c84e) into main (f52177f) will not change coverage. The diff coverage is
n/a
.:exclamation: Current head 073c84e differs from pull request most recent head 2022549. Consider uploading reports for the commit 2022549 to get more accurate results
@@ Coverage Diff @@
## main #291 +/- ##
===========================================
Coverage 94.3111% 94.3111%
===========================================
Files 13 13
Lines 1125 1125
===========================================
Hits 1061 1061
Misses 56 56
Partials 8 8
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f52177f...2022549. Read the comment docs.
This PR adds more descriptive messages to failing tests.
Example 1
A missing/incorrect field in ordered transactions is difficult to deduce from the error message.
For the following code:
The current error is as follows:
This is my attempt at a solution:
Example 2
When matching single transactions, it is sometimes tricky to see which fields are affected when two transactions are not equivalent. The following error is not the best example, but I've had cases where it's really difficult to find the field that is wrong, especially when working with arrays.
Becomes this:
Example 3
We should be able to see which transactions occurred instead of knowing that one is missing.
Currently, we get the following message:
Now, we get this message:
Additionally, made
Move
check a strict match similar to how Pokemon are compared in the matchers. Closes #289