Closed dyc3 closed 3 years ago
Merging #295 (3f14944) into main (fcad799) will increase coverage by
0.4623%
. The diff coverage is98.4375%
.:exclamation: Current head 3f14944 differs from pull request most recent head e0d1487. Consider uploading reports for the commit e0d1487 to get more accurate results
@@ Coverage Diff @@
## main #295 +/- ##
================================================
+ Coverage 95.1690% 95.6314% +0.4623%
================================================
Files 14 14
Lines 1449 1465 +16
================================================
+ Hits 1379 1401 +22
+ Misses 60 53 -7
- Partials 10 11 +1
Impacted Files | Coverage Δ | |
---|---|---|
battle.go | 91.3157% <98.2758%> (+0.4067%) |
:arrow_up: |
transactions.go | 91.3793% <100.0000%> (-0.0493%) |
:arrow_down: |
pokemon.go | 97.2602% <0.0000%> (+4.1095%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fcad799...e0d1487. Read the comment docs.
This PR is an effort to consolidate how pokemon are accessed into one easy mechanism. An added bonus is a potentially reduced lifetime for values copied when creating battle contexts for Agents, which would mean less memory usage over general usage.
Now the code more clearly defines where pokemon are copied, and where pokemon are passed by reference.
Another bonus, it closes #294