search

Steveorevo / node-red-contrib-actionflows

Provides a set of nodes to enable an extendable design pattern for flows.
45 stars 12 forks source link

Problem with 0.20 version of NodeRed #4

Closed gidoUninova closed 5 years ago

gidoUninova commented 5 years ago

Dear Stephen,

I upgrade my nodered to the LTS (0.20 version). Since I did that my action flows are not fully working. In particular, they works if action_in and action_out are in a tab (parent flow), however if I put them in a subflow they are not working. I noticed that in the LTS version of nodered, the developers made some enhancements to the subflows part, and I believe that this could have impact in your logic. Are you able to test the action flows with the LTS version of nodered and using subflows?

Cheers,

Giovanni

Steveorevo commented 5 years ago

Hi Giovanni, I'll try to make time to look into this. I haven't upgraded yet. To make things faster, can you upload/attach a basic flow that illustrates this issue?

gidoUninova commented 5 years ago

Hi Stephen,

attached you can find a simple flow for testing.

Cheers,

Giovanni

ActionFlowsExample.txt

aabluedragon commented 5 years ago

Hello @Steveorevo ,

Please check out the following pull request for fixing this issue https://github.com/Steveorevo/node-red-contrib-actionflows/pull/7

Thanks, Alon

Steveorevo commented 5 years ago

Hello @aabluedragon , Looks good. Tested against @gidoUninova 's example and appears to resolve the issue for compatibility with Node-RED 0.20. Will push new release shortly. Thank you for contributing!

Regards, Steve