Steveplays28 / biomefog

Minecraft Fabric mod that adds unique fog to a bunch of biomes!
https://www.curseforge.com/minecraft/mc-mods/biome-fog
Other
1 stars 4 forks source link

Crash when rendering Water Fog - 1.20 #19

Closed careeoki closed 1 year ago

careeoki commented 1 year ago

Entering water (deep enough to submerge player's head) instantly crashes my game. Very sad :(

Crash log: crash-2023-07-17_12.36.03-client.txt

My mod list, if it's a compatibility error:

Thank you! I really like the mod.

Steveplays28 commented 1 year ago

I only reproduced this once in a large modpack I'm working on, but never got it again after. Not sure what happens here but it seems like another mod touches the world variable in Minecraft's BackgroundRenderer, causing issues.

Could you rule out which mod is the issue via a binary search?

careeoki commented 1 year ago

crash-2023-07-22_10.41.51-client.txt I still get the same crash, even with just Biome Fog + Fabric API. I also tried updating to the latest Fabric API (the one listed on Biome Fog's download page) and Fabric loader version, but I get the same crash again.

Steveplays28 commented 1 year ago

What does your config/biome_fog folder look like? Are the two config files biome_fog.json and biome_fog_blacklisted_worlds.json present?

careeoki commented 1 year ago

Both are present. I have not changed any configurations

EthanRDoesMC commented 1 year ago

Here to report the same issue, mostly different set of mods. crash-2023-07-24_21.10.20-client.txt

edit: Just wanted to add that I tried it with Quilt to the same effect

Alomare commented 1 year ago

Same here. Big mod list as well crash-2023-07-25_00.20.27-client.txt

Steveplays28 commented 1 year ago

Still haven't been able to reproduce this but I have a potential solution in mind, I'll let you guys know when I've gotten around to it and you can test it.

Steveplays28 commented 1 year ago

Will release a hotfix later today! Thank you to @Leva25se for fixing this issue.

Steveplays28 commented 1 year ago

The fix for this issue has been released in v1.1.1.