Steveplays28 / noisium

Minecraft mod that optimises worldgen performance for a better gameplay experience.
https://www.curseforge.com/minecraft/mc-mods/noisium
Other
91 stars 6 forks source link

Fluids not rendered until player interaction (right click) #16

Closed SirBob27 closed 6 months ago

SirBob27 commented 7 months ago

At times, certain parts of lava or water streams can be rendered invisible. Occurs throughout both overworld and nether. Not sure if this is a mod compatibility error. Images: image Part of lava stream is invisible. image Stays invisible after block update.

Mods list: Health Indicator TXF https://modrinth.com/mod/health-indicator-txf Mod Menu https://modrinth.com/mod/modmenu NBT AutoComplete https://modrinth.com/mod/nbt-autocomplete Dynamic FPS https://modrinth.com/mod/dynamic-fps Xaero’s Worldmap https://modrinth.com/mod/xaeros-world-map Zoomify https://modrinth.com/mod/zoomify Better Statistics https://modrinth.com/mod/better-stats BetterF3 https://modrinth.com/mod/betterf3 Debugify https://modrinth.com/mod/debugify Chat Heads https://modrinth.com/mod/chat-heads More Culling https://modrinth.com/mod/moreculling Entity Culling https://modrinth.com/mod/entityculling ModernFix https://modrinth.com/mod/modernfix FerriteCore https://modrinth.com/mod/ferrite-core Peek https://modrinth.com/mod/peek Immediately Fast https://modrinth.com/mod/immediatelyfast Status Effect Bars https://modrinth.com/mod/status-effect-bars Who Am I? https://modrinth.com/mod/whoami Concurrent Chunk Management Engine https://modrinth.com/mod/c2me-fabric Thread Tweak https://modrinth.com/mod/threadtweak Lazy Language Loader https://modrinth.com/mod/lazy-language-loader AppleSkin https://modrinth.com/mod/appleskin Simple Item Editor https://modrinth.com/mod/simple-item-editor Screenshot to Clipboard https://modrinth.com/mod/screenshot-to-clipboard Very Many Players https://modrinth.com/mod/vmp-fabric Xaero’s Minimap (Fair Play) https://modrinth.com/mod/xaeros-minimap-fair Better Mount HUD https://modrinth.com/mod/better-mount-hud CustomHud https://modrinth.com/mod/customhud 
 Krypton https://modrinth.com/mod/krypton Lithium https://modrinth.com/mod/lithium
Bad Optimizations https://modrinth.com/mod/badoptimizations Fast Quit https://modrinth.com/mod/fastquit Fast IP Ping https://modrinth.com/mod/fast-ip-ping 
 Paginated Advancements https://modrinth.com/mod/paginatedadvancements Minecraft Capes https://modrinth.com/mod/minecraftcapes Your Options Shall be Respected https://modrinth.com/mod/yosbr e4mc https://modrinth.com/mod/e4mc LazyDFU https://modrinth.com/mod/lazydfu Totem Small Pop https://modrinth.com/mod/cpvp Sodium https://modrinth.com/mod/sodium Gamma Shifter https://modrinth.com/mod/gamma-shifter NoFog https://modrinth.com/mod/no_fog Noisium https://modrinth.com/mod/noisium

Using dark ui resource pack from vanillatweaks.net

SirBob27 commented 7 months ago

Sorry, accidentally closed issue

SirBob27 commented 7 months ago

Important to note, player still gets set on fire in invisible lava. I'd assume invisible water would have similar effects, but I have yet to test it.

Steveplays28 commented 7 months ago

Could be due to #10, for which I opened an issue in Lithium's repository.

SirBob27 commented 7 months ago

Definitely possible, but entities treat the unrendered sections as normal lava/water, instead of simply going through it. It's kind of like the opposite effect; the client just doesn't render it. Not tested on a server with noisium installed.

SirBob27 commented 7 months ago

I'll try to create a testing world in which I can run through the issue more thoroughly.

SirBob27 commented 7 months ago

image Strangely enough, after spawning an entity using a spawn egg on an invisible flowing lava, the lava becomes fully visible again and does not revert to its invisible state.

Screenshot 2024-02-22 at 3 31 10 PM
SirBob27 commented 7 months ago

Apparently needs to be a player interaction. Using /summon does not cause the lava to render. Placing armor stands using an item works.

SirBob27 commented 7 months ago

Something I forgot to check earlier, but you actually only need to right click where the invisible fluid is. No entity spawning needed. Left clicking does nothing.

Steveplays28 commented 6 months ago

This should be fixed in v2.0.2, since I've added Lithium compatibility. Let me know if any (other) issues arise.

SirBob27 commented 6 months ago

Thanks! The fix seems to be working perfectly.

Steveplays28 commented 6 months ago

Awesome, glad to hear.