Steveplays28 / noisium

Minecraft mod that optimises worldgen performance for a better gameplay experience.
https://www.curseforge.com/minecraft/mc-mods/noisium
Other
91 stars 6 forks source link

Crash when creating new chunk in ad_astra dimension #25

Closed mberlin1 closed 6 months ago

mberlin1 commented 6 months ago

Game verison: 1.20.1 Noisum version: noisium-forge-2.0.2+mc1.20-1.20.1

how to reproduce: take a new world from monumental's 1.20.1 modpack. spawn yourself a launchpad and tier 2 rocket spawn yourself 64 desh ingots and 64 desh plates, 64 steel ingots and 64 iron plates hop into the rocket, blast off in earth orbit, click on the plus sign and try to build a space station. Crash. Crash log attached. new 1.txt

Steveplays28 commented 6 months ago

You ran out of memory according to the stack trace. Could you try it with more memory, and with a minimal set of mods?

mberlin1 commented 6 months ago

Ran out of memory? it's running with 24 gigabytes of ram.

On Fri, Apr 19, 2024 at 7:04 AM Darion Spaargaren @.***> wrote:

You ran out of memory according to the stack trace. Could you try it with more memory, and with a minimal set of mods?

— Reply to this email directly, view it on GitHub https://github.com/Steveplays28/noisium/issues/25#issuecomment-2066340606, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2UT7G3UJYZC7H45P5YAJDY6D2ZZAVCNFSM6AAAAABGOLKU6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRWGM2DANRQGY . You are receiving this because you authored the thread.Message ID: @.***>

Steveplays28 commented 6 months ago

I don't see anything referencing Noisium in that log file, nor do I see Noisium's loading log message. As said, would you mind trying with a minimal set of mods to ensure that Noisium is the issue?

mberlin1 commented 6 months ago

Sure, i'll get you a log. If you have a suggestion for whose code might be involved in resolving the chunk creation and subsequent crash, i'm open to suggestions.

On Fri, Apr 19, 2024 at 9:00 AM Darion Spaargaren @.***> wrote:

I don't see anything referencing Noisium in that log file, nor do I see Noisium's loading log message. As said, would you mind trying with a minimal set of mods to ensure that Noisium is the issue?

— Reply to this email directly, view it on GitHub https://github.com/Steveplays28/noisium/issues/25#issuecomment-2066528710, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2UT7HHSD46S2YFPIAGQJLY6EIQFAVCNFSM6AAAAABGOLKU6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRWGUZDQNZRGA . You are receiving this because you authored the thread.Message ID: @.***>

Steveplays28 commented 6 months ago

Just realized that this might be the same issue holmraven reported in my Discord server one and a half weeks ago. I'll do some further investigating.

Luviam commented 6 months ago

Tested this with a fresh profile and only Ad Astra, Noisium, and lib mods. I Also crashed but not due to memory. Here's my log if it helps. latest.log

3dEADto2 commented 6 months ago

I have the same crash with create: dreams and desires or the graveyard (fabric 1.20.1, noisium ver. 2.0.2) latest.log crash-2024-04-24_02.59.37-server.txt

Steveplays28 commented 6 months ago

These issues all seem like the same issue as in #22. Might change the array back into a Set/ArrayList, since whatever check Minecraft is doing to give the array its initial size is incompatible with mods.

Steveplays28 commented 6 months ago

Fixed in v2.0.3. Thanks for the report!