search

Stevertus / objD

objD is a framework for developing Datapacks for Minecraft. It uses the Dart programming language.
https://objd.stevertus.com
BSD 2-Clause "Simplified" License
46 stars 13 forks source link

Update context.version, fix scoreboard conflicts with PlayerJoin, add "rejoin" method to PlayerJoin #24

Closed Synthetic-Dev closed 2 years ago

Synthetic-Dev commented 2 years ago

Updated the context.version default and checks for 1.18 formatting, fixed scoreboards being overridden when an operation is used on them before they are added to the tree. Added a "rejoin" method to PlayerJoin that takes the behaviour of the default PlayerJoin constructor, which now accounts for when the player first joins the world.

Synthetic-Dev commented 2 years ago

The debug messages are removed in the Fix scoreboard overwrites commit

Stevertus commented 2 years ago

The debug messages are removed in the Fix scoreboard overwrites commit

A yes sorry you are right. But in the same commit is the `removeOld`` really needed? In which cases do you use it and why not simple Scoreboard.remove?

Synthetic-Dev commented 2 years ago

It is just a feature that I am using in a datapack for convenience, do you want it removed?

Stevertus commented 2 years ago

Is that solely for easier debugging, when changing the type? As said I don't see a use case other than multiple scoreboards with different types generated and thus removed it