Update upnp handling - Githubissues

SteveyO / Hue-Emulator

A Bridge API Emulator for the Philips Hue (Personal Wireless System)

165 stars 41 forks source link

Update upnp handling #20

Open bwssytems opened 8 years ago

bwssytems commented 8 years ago

I have an update to do upnp handling like a hue hub. I have refactored some http server requests and how ssdp is handled in multicast.

SteveyO commented 8 years ago

Thanks for this, all contributions always welcome as am not actively developing the emulator at the moment. I will need to check out in greater detail before merging. I had a quick 15min test earlier:

Looks like you solved the rootContext /description.xml issue which is great :-)
I tried with the QuickStart Android App and it didn't seem to find the bridge every search (approx the same amount as the original UPNP implementation). Need to check this in greater detail.
I saw a bit of extra console logging (e.g favicon.ico). This would need cleaning. I can do this. Am not a massive fan on the extra dependencies but I can live with this.

At some point soon I will create the v0.6.jar with all the recent updates.

bwssytems commented 8 years ago

I'll try the Android App. I used the Philips SDK Java Desktop app to test.

The console logging I put in for debugging.

The dependencies were small. I hate dependencies too. The other app that I have I had redone from the original as it was dependent on spring framework, ughh. That version was a 37mb jar. I used some smaller frameworks and got it down to 3.6mb jar. It's much faster and runs on a pogoplug just fine.

Glad to help.

bwssytems commented 8 years ago

Also, I noticed you don't set a specific IP when starting the servers. If you are multi-homed, you may not be on the correct IP when responding with the description.xml.

SteveyO commented 8 years ago

Sorry for the late response. I have just released v0.6 of the emulator. I cherry picked some of this code, in particular the refactoring of the 2 web contexts and the description.xml. Sorry I didn't take the rest as not got the chance to fully test it yet, and as I mentioned the UPnP wasn't detected by the Java SDK.

bwssytems commented 8 years ago

No problem. Just wanted to contribute.

Thanks

Brad

--------- Original Message --------- Subject: Re: [Hue-Emulator] Update upnp handling (#20) From: "Steve" notifications@github.com Date: 12/1/15 7:55 am To: "SteveyO/Hue-Emulator" Hue-Emulator@noreply.github.com Cc: "bwssytems" info@bwssystems.com

Sorry for the late response. I have just released v0.6 of the emulator. I cherry picked some of this code, in particular the refactoring of the 2 web contexts and the description.xml. Sorry I didn't take the rest as not got the chance to fully test it yet, and as I mentioned the UPnP wasn't detected by the Java SDK.

Reply to this email directly or view it on GitHub.