search

Stewart86 / roadtaxTracker

CRUD operation for a fleet of vehicle in Singapore to ease roadtax renewal
MIT License
8 stars 35 forks source link

To be more pythonic #6

Closed cyberhobbes closed 5 years ago

cyberhobbes commented 5 years ago

The original code called the car_plate() and goods_plate() twice in one condition. That will cause two license plates to generate, but only the last one will be used. With this fix, Generate() will be 50% faster.

Stewart86 commented 5 years ago

@cyberhobbes Thanks for the commit! Nice work.

cyberhobbes commented 5 years ago

Hi Stewart,

Is this pull request merged to master?

Stewart86 commented 5 years ago

@cyberhobbes I was unable to merge your pull request as your repository was not found. You might have to reopen another separate pull request.