Stewart86 / roadtaxTracker

CRUD operation for a fleet of vehicle in Singapore to ease roadtax renewal
MIT License
8 stars 35 forks source link

Moved suffix generation in vehicleGen.py #9

Closed MythreyaK closed 4 years ago

MythreyaK commented 4 years ago

Suffix for a vehicle is generated in 2 places with the same identical code. This commit moves the suffix generation into a function get_suffix() to prevent duplicated effort in maintaining 2 copies.

Feedback welcome!

P.S: I was unable to run the tests due to an error. I'll try it again, if it doesn't work, I'll leave the message in a separate issue.

Still a beginner to GitHub and Git, please be gentle!