Stewmath / GameYob

[Super] Gameboy [Color] emulator for the Nintendo [3]DS
MIT License
270 stars 59 forks source link

Proper Invalid Bankswitch Emulation #164

Closed ParzivalWolfram closed 6 years ago

ParzivalWolfram commented 6 years ago

I've added proper invalid-bank switching behavior. Should make some homebrew and bootlegs more stable. (Don't mind my stupid commit names)

Stewmath commented 6 years ago

Also, so I can test this later, can you give an example of a homebrew that this fixes?

ParzivalWolfram commented 6 years ago

I don't have a specific example, but I know there are a few. Also, I removed the DSi lines because they kept me from compiling successfully for some reason. I'm guessing you already saw what I was trying to do at first, but I couldn't get it to work for some reason... it just wasn't cooperating. Probably for the best, anyway xD

On Thu, Apr 12, 2018 at 12:17 PM, Drenn1 notifications@github.com wrote:

Also, so I can test this later, can you give an example of a homebrew that this fixes?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Drenn1/GameYob/pull/164#issuecomment-380880513, or mute the thread https://github.com/notifications/unsubscribe-auth/AcnhQWX2UAY3rBRP1q13aKW07HAHL3O8ks5tn4wpgaJpZM4TR2am .

Stewmath commented 6 years ago

To be fair, it's been a while since I compiled this branch. Maybe some of those changes were needed. (I more recently worked on the v0.5-hotfix branch.)

ParzivalWolfram commented 6 years ago

Yeah, there are several issues with the pre-existing code... of course, my added code caused even more, which is why I undid my changes.

On Thu, Apr 12, 2018 at 1:32 PM, Drenn1 notifications@github.com wrote:

To be fair, it's been a while since I compiled this branch. Maybe some of those changes were needed. (I more recently worked on the v0.5-hotfix branch.)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Drenn1/GameYob/pull/164#issuecomment-380902683, or mute the thread https://github.com/notifications/unsubscribe-auth/AcnhQVcJvXIMtel_gg4Sk9yDMTMY9lNzks5tn53TgaJpZM4TR2am .

ParzivalWolfram commented 6 years ago

\GameYob/platform/ds/arm7/source/main.c: In function 'powerHandler': GameYob/platform/ds/arm7/source/main.c:148:14: error: 'PM_DSI_HACK' undeclared (first use in this function) case PM_DSI_HACK: ^~~~~~~~~~~ Yeah, it's busted. xD

ParzivalWolfram commented 6 years ago

Fixed the tab issue.

ParzivalWolfram commented 6 years ago

@Drenn1 I fixed the tab issue (i think)

ParzivalWolfram commented 6 years ago

yeah no, just reject this

i'm just gonna make it a parallel project

Stewmath commented 6 years ago

Well, feel free to make another PR when this is ready... no reason to fork the codebase unless this has a large speed impact.