Stewmath / GameYob

[Super] Gameboy [Color] emulator for the Nintendo [3]DS
MIT License
272 stars 59 forks source link

Bilinear filter option request, should not hinder performance! #175

Open Nashismo opened 4 years ago

Nashismo commented 4 years ago

Hi Drenn:

First of all let me tell you, your emulator is the most amazing thing ever created for the DS, so great that is even better than any emu on the 3DS to emulate the Gameboy.

I am sure you know that, but my request is simple. Would you add bilinear filter when scaling the resolution on this emulator?

See, the thing is this, the games when stretched look bad and wrong and not only that, but beacause NOT having a bilinear filter option, this creates noise when moving on a game horizontally!

This is the reason why Nintendo themselves use "Bilinear filtering" for their GB games on the VC. Not only the games look better (hiding the upscaling deformations) but also "bilinear filter" eliminates this noise when scrolling in games.

This is the only feature that stops your emulator from being perfect. The VC options on the 3DS by Nintendo lack so many options your emulators already has (colorisation of GB games, change button layout, SGB borders, etc).

This would be the world for me, and I think it would mean so much to everyone else with scaling problems.

My regards and please consider this option! Retroarch on 3DS has bilinear filter integrated by default (does NOT hinder performance), but the GB emulators are terrible there, leaps and bounds behind your emulator!

I humbly ask you for this, thank you with all my heart., Nashismo.

andrebrait commented 4 years ago

The Lameboy DS dev said getting bilinear filtering on the DS was easily done with a small trick, but I'm not sure what

Nashismo commented 4 years ago

The Lameboy DS dev said getting bilinear filtering on the DS was easily done with a small trick, but I'm not sure what

If we could only know how could be done... Lameboy is very old now and I cannot find any github page to communicate with the dev. Mmm, I know that using Retroarch by default it makes all emus use bilinear filtering if you so choose.

Asking Drenn to port his emu to retroarch for 3ds would be another option? Personally I don't like Retoarch and love this emu just the way it is, only bilinear filtering is missing.

Well if you can find any info please let me know! I will try to contact the Lameboy dev somehow and I will update this thread if/when I find any info.

Cheers Andre!

Nashismo commented 4 years ago

OK, I checked Lameboy 0.9 wich supposed to be using bilinear filtering. But no, it is using "some kind" of filtering, but it is NOT bilinear filtering.

Bilinear filtering is much stronger and most importantly it gets rid of the bad scaling and the horizontal/vertical scrolling issues. Retroarch would be our only option, but there isn't any good GB emulators there. Porting Gameyob would be ideal, but I don't know if it is possible.

ParzivalWolfram commented 4 years ago

isn't any good GB emulators there You know that all the GBx emulators in Retroarch are more accurate than GameYob and Lameboy, with the exception of possibly TGB Dual, right? Including the ones on the 3DS?

On Monday, December 23, 2019, Nashismo notifications@github.com wrote:

OK, I checked Lameboy 0.9 wich supposed to be using bilinear filtering. But no, it is using "some kind" of filtering, but it is NOT bilinear filtering.

Bilinear filtering is much stronger. Retroarch would be our only option, but there isn't any good GB emulators there. Prting Gameyob would be ideal, but I don't know if it is possible.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Drenn1/GameYob/issues/175?email_source=notifications&email_token=AHE6CQOSA6BCQKDYLBS2VJ3Q2BQR7A5CNFSM4JX7N73KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHQNG4Q#issuecomment-568382322, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHE6CQKG62DFO4NCI3QPOKDQ2BQR7ANCNFSM4JX7N73A .

Nashismo commented 4 years ago

isn't any good GB emulators there You know that all the GBx emulators in Retroarch are more accurate than GameYob and Lameboy, with the exception of possibly TGB Dual, right? Including the ones on the 3DS?

Why do you think such a thing? Why do you "believe" that Gameyob is in any way "less accurate" than Gambatte for example? Have you read the source code of each emu yourself? Do you have years of working as a developer of any emulator?

Gambatte is "supposed" to be aiming for accuracy, sure, but does that goal from Gambatte developers makes Gameyob any less accurate?

Gameyob is the best and most accurate emulator, period, for the DS and 3ds console (in terms of final results on screen/sound). We are not talking about PC or any other platform, in which Gambatte works as intended.

I have tested dozens, actually hundreds of games between real hardware and Gameyob vs Gambatte and 3ds VC. And Gameyob and the 3DS VC are the ones that are the most accurate and faithfull to original hardware as it gets!

Gambatte and TGB Dual perform horrible and are full of bugs (specially TGB Dual) on the 3ds, sound problems are huge, these emulators run terrible on the 3ds, have you even tested them?

I am a perfectionist and I can tell any differences between real hardware vs emulation, same reason why I am asking for this feature.

ParzivalWolfram commented 4 years ago

If I may direct your attention to https://github.com/ParzivalWolfram/GameYob-Accurate. For more info: https://youtu.be/oQZMVo_Fmrs and https://github.com/Gekkio/mooneye-gb.

EDIT: also, I have an N3DS XL, so your emulation issues may be due to being on O3DS, as the New hardware variant has much better hardware. (Also, your N2DS only has the actual New hardware if it folds. Why? Ask Nintendo...)

And yes, I can pull fullspeed with Gambatte (and even fast forward to a limited degree!)

On Tuesday, December 24, 2019, Nashismo notifications@github.com wrote:

isn't any good GB emulators there You know that all the GBx emulators in Retroarch are more accurate than GameYob and Lameboy, with the exception of possibly TGB Dual, right? Including the ones on the 3DS? … <#m-7226161245435327725> On Monday, December 23, 2019, Nashismo @.***> wrote: OK, I checked Lameboy 0.9 wich supposed to be using bilinear filtering. But no, it is using "some kind" of filtering, but it is NOT bilinear filtering. Bilinear filtering is much stronger. Retroarch would be our only option, but there isn't any good GB emulators there. Prting Gameyob would be ideal, but I don't know if it is possible. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <

175 https://github.com/Drenn1/GameYob/issues/175?email_source=

notifications&email_token=AHE6CQOSA6BCQKDYLBS2VJ3Q2BQR7A 5CNFSM4JX7N73KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5 WW2ZLOORPWSZGOEHQNG4Q#issuecomment-568382322>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ AHE6CQKG62DFO4NCI3QPOKDQ2BQR7ANCNFSM4JX7N73A .

Why do you think such a thing? Why do you "believe" that Gameyob is in any way "less accurate" than Gambatte for example? Have you read the source code of each emu yourself? Do you have years of working as a developer of any emulator?

Gambatte is "supposed" to be aiming for accuracy, sure, but does that goal from Gambatte developers makes Gameyob any less accurate?

Gameyob is the best and most accurate emulator, period, for the DS and 3ds console. We are not talking about PC or any other platform, in which Gambatte works as intended.

I have tested dozens, actually hundreds of games between real hardware and Gameyob vs Gambatte and 3ds VC. And Gameyob and the 3DS VC are the ones that are the most accurate and faithfull to original hardware as it gets!

Gambatte and TGB Dual perform horrible and are full of bugs (specially TGB Dual) on the 3ds, sound problems are huge, these emulators run terrible on the 3ds, have you even tested them?

I am a perfectionist and I can tell any differences between real hardware vs emulation, same reason why I am asking for this feature!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Drenn1/GameYob/issues/175?email_source=notifications&email_token=AHE6CQIHU67ZAT5O4ZRKIDDQ2LNGNA5CNFSM4JX7N73KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHT3WCI#issuecomment-568834825, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHE6CQJFGQS2OWQ3GNCYYZLQ2LNGNANCNFSM4JX7N73A .

Nashismo commented 4 years ago

If I may direct your attention to https://github.com/ParzivalWolfram/GameYob-Accurate. For more info: https://youtu.be/oQZMVo_Fmrs and https://github.com/Gekkio/mooneye-gb. EDIT: also, I have an N3DS XL, so your emulation issues may be due to being on O3DS, as the New hardware variant has much better hardware. (Also, your N2DS only has the actual New hardware if it folds. Why? Ask Nintendo...) And yes, I can pull fullspeed with Gambatte (and even fast forward to a limited degree!)

It is true, I have the Original 2ds, actually I have the 2ds Mario Maker model, it feels like a Gameboy :) and I replaced the dpad with a GBA dpad, so that's why I prefer it to any other 3ds! It is the most comfortable 3ds and the most similar to the OG gameboy.

So then, that is my problem, my 2ds is too weak... It is a shame, if you want or need some help testing your Gameyob accurate version, I have free time to waste and test, etc, if you ever need that.

According to your experience then, would it be possible to port Gameyob (standard version) to Retroarch 3ds? Because to me (and people with my hardware), this would be the best option.

Thank you and well, who knew you were a developer hahhhaha, it's great and let me know if I can help in any way.

ParzivalWolfram commented 4 years ago

No problem! Always glad to clear up confusion. I've got a lot of IRL stuff going on, so GY-A is gonna get pretty outdated... hopefully I'll be able to get it finished after college, if not sooner. The RetroArch system runs on libretro, which is built to be plug & play for emulators with little modification, so it should be very possible to do. However, a lot of the speed benefit from GameYob would be lost as LibRetro would be handling video, sound, input, etc.

On Wednesday, December 25, 2019, Nashismo notifications@github.com wrote:

If I may direct your attention to https://github.com/ ParzivalWolfram/GameYob-Accurate. For more info: https://youtu.be/oQZMVo_Fmrs and https://github.com/Gekkio/mooneye-gb. EDIT: also, I have an N3DS XL, so your emulation issues may be due to being on O3DS, as the New hardware variant has much better hardware. (Also, your N2DS only has the actual New hardware if it folds. Why? Ask Nintendo...) And yes, I can pull fullspeed with Gambatte (and even fast forward to a limited degree!) … <#m-3590244490877898148>

It is true, I have the Original 2ds, actually I have the 2ds Mario Maker model, it feels like a Gameboy :) and I replaced the dpad with a GBA dpad, so that's why I prefer it to any other 3ds! It is the most comfortable 3ds and the most similar to the OG gameboy.

So then, that is my problem, my 2ds is too weak... It is a shame, if you want or need some help testing your Gameyob accurate version, I have free time to waste and test, etc, if you ever need that.

According to your experience then, would it be possible to port Gameyob (standard version) to Retroarch 3ds? Because to me (and people with my hardware), this would be the best option.

Thank you and well, who knew you were a developer hahhhaha, it's great and let me know if I can help in any way.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Drenn1/GameYob/issues/175?email_source=notifications&email_token=AHE6CQPV2PS7GT3MTGSYWMTQ2MA4BA5CNFSM4JX7N73KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHUAHKA#issuecomment-568853416, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHE6CQOO4GLS7D243TSTAALQ2MA4BANCNFSM4JX7N73A .

Nashismo commented 4 years ago

No problem! Always glad to clear up confusion. I've got a lot of IRL stuff going on, so GY-A is gonna get pretty outdated... hopefully I'll be able to get it finished after college, if not sooner. The RetroArch system runs on libretro, which is built to be plug & play for emulators with little modification, so it should be very possible to do. However, a lot of the speed benefit from GameYob would be lost as LibRetro would be handling video, sound, input, etc.

I understand. Still, as Gameyob was meant to run on the original DS, I think in terms of speed it could run quite well even in O3DS hardware, if ported right.

I know Steveice made a port of Gameyob for the 3ds, but it runs quite slow, quite badly. I guess I will go beg him to try and port it to Retroarch, it seems like the better option. Also I am from Chile, so my english is different, I learned a long time ago, with old americans who spoke english.

My best regards.