search

Stewmath / GameYob

[Super] Gameboy [Color] emulator for the Nintendo [3]DS
MIT License
270 stars 59 forks source link

Game custom Borders Full Screen don't work #191

Open InfiniteWorldLegacy opened 2 years ago

InfiniteWorldLegacy commented 2 years ago

Hello, I'll detail things bellow:

Model: Old 3DS XL Emulator version: GameYob v0.5.2 - Modified upon the DS version by Drenn. SGB Border: On Custom Border: On Behavior: 1 - When in default/original GB/GBC resolution Borders appear just fine 2 - When Y is pressed, game enters ''full screen mode'' but borders disappear completetly. Expected Behavior: Game enters full screen and crops some of the border, but not everything. Check this guy's video at 5:17, when he presses Y, borders don't disappear in full screen. https://www.youtube.com/watch?v=xl09ncl3qUw

Anyways to have some little borders when in Full screen? tks

Stewmath commented 2 years ago

Custom borders don't work with scaling because, due to various shenanigans required for scaling to work properly, there isn't enough space in VRAM for the custom border graphics. At least, that's what I recall from when I was working on it 8-9 years ago.

SGB borders do work because they don't require as much VRAM space to display.

Then again, maybe the DSi has extra VRAM that could be used for this? If so then it would be possible to implement.

InfiniteWorldLegacy commented 2 years ago

I see what you mean now. I tested pokemon gold's ROM and it does behave like you said. GameYob loads pokemon Gold's SGB default border and when pressing Y, it crops some of it but not all. For some reason I thought it would work with custom borders but it doesn't. Thank you very much for your answer.

I've noticed that the other build, from Steve 1.0.8 it does load the borders even in full screen which is great but..... That version has some choppy sound issues with some titles. But your v0.5.2 audio works fine almost flawless Longshort story: v0.5.2 won't work with custom borders in full screen but its gaming performance is almost flawless. V1.0.8 works with custom borders in full screen but it will have some sound issues