search

Stewmath / GameYob

[Super] Gameboy [Color] emulator for the Nintendo [3]DS
MIT License
270 stars 59 forks source link

Fix desync on netplay start #193

Open tilderain opened 2 years ago

tilderain commented 2 years ago

I noticed random inputs on netplay start when implementing GameYob's multiplayer into Cave Story DS, and this commit should fix it. Unfortunately I can't test this as I don't have two flashcarts, but I can confirm that this did fix the desync problems I was having during early multiplayer testing. There are a few more improvements I'd like to push as well (same frame delay on client and host, don't disconnect when packets aren't received, set SRAM transfer packet to require acknowledge), but I think this is ok for now.

Stewmath commented 2 years ago

I don't think I want to merge this for now without it having been tested, but I'll look into it if I ever come back to this. The memsets by themselves are fine but I'm not sure about the other lines that were removed. At least, I couldn't say for sure without testing it myself.