Stewmath / GameYob

[Super] Gameboy [Color] emulator for the Nintendo [3]DS
MIT License
272 stars 59 forks source link

SGB Border Issues #58

Closed ghost closed 11 years ago

ghost commented 11 years ago

Currently I am running GameYob v0.3-66-ge542 [04/21/13 FINAL]

I can only get the SGB Borders to appear when my settings are set to this:

SGB Borders: On [not trying to use custom borders right now, therefore ; Custom Border: Off] GBC Mode: On GBC Bios: On SGB Mode: Prefer - SGB

{side note - when switching these setting to this:

SGB Borders: On SGB Mode: Off

it will drop the borders and leave the group of pixels where they were in white}

Currently there is no way or exploit that allows you to have SGB Borders if you want to run a game with full GBC Colors, you are stuck using grey or some other spooky color setting I have never seen. I don't understand if this is a bug or an enhancement, because when you run with options set to this:

SGB Borders: On SGB Mode: Off GBC Bios/Mode - On + On, ect - no border appears.

I'd just like to have more control on the display options, such as running with normal GBC options, no SGB mode enabled, but still have Borders enabled and actually have them display.

Stewmath commented 11 years ago

I literally just got the borders working yesterday, I do intend to make border usage more flexible. Here are my plans:

Sgb borders are usually game-specific, so they disappear / are replaced by the default border when another game is loaded. (It would make sense to not overwrite them when just resetting a game.) But if it's a really nice border, then see my third point, you'll be able to dump it to use as a custom border. Maybe. The sgb border and custom border formats are actually completely different, so, we'll see.

This is an enhancement request, except for the backdrop colour being changed when the border is disabled, that's a bug.

Stewmath commented 11 years ago

I've done the first bit of what I said. Games supporting both GBC and SGB are "probed" for their SGB borders. That is, they're started up in SGB mode for just long enough to receive a border. Then they're restarted in GBC mode. Also I think I've fixed the backdrop colour glitch when borders are disabled, but I wasn't testing that very much.

etking commented 11 years ago

Just want to report that the SGB borders of some Rareware games like Donkey Kong Land 2 or Killer Instinct seem to get corrupted. Maybe they use a different compression format?

etking commented 11 years ago

The latest SGB border fixes seem to have broken GBC bios loading entirely, it does not load anymore, even if GBC modes are enabled and all SGB features are disabled. And are there plans to support SGB2 borders as well?

It would also be great to see SGB palette switching and support for the default SGB borders that come with the SGB.

Stewmath commented 11 years ago

For some reason I changed how it looks for the bios, if it's not in the /lameboy directory it won't be picked up at all unless specified in "gameyob.ini". I'm not really sure why I did that... I'd better change it back to how it was.

etking commented 11 years ago

Hm, I think a central location would actually be better, especially if you use many sub folders to organize your files you would not need to put the bios files in each of them.

But it should not depend on an absolute path, for example I do not have a lameboy directory and putting the files in the directory where the gameyob.nds is located did not fix it. By the way it would be great if gameyob could save the last used game directory.

ghost commented 11 years ago

The default directory for GameYob is Lameboy, this makes it very easy for many people, including myself, who used to use Lameboy to use GameYob. I myself just keep the bios and all of my games in one folder, it makes it easy.

Stewmath commented 11 years ago

There are options in gameyob.ini to specify your rom directory and the location of the gbc bios. Just open it up with a text editor after saving your settings at least once. When I get around to it I'll make the current directory saved to gameyob.ini so people don't need to know about that.

etking commented 11 years ago

This makes sense. The DStwo-plugins offered on gbatemp require the gameyob.nds to be placed in another directory by default, thats why it stopped working for me. I also currently have a separate, easier to recognize folder for games.

etking commented 11 years ago

When SGB borders are disabled in settings, games should start immediately, without the flickering when being checked for borders because no check is necessary. Gameyob maybe also should cache the results by filename and checksum, so that the availability of SGB borders does not need to be checked with heavy flickering every time.

Stewmath commented 11 years ago

I already did stop it from trying to load SGB borders when it isn't enabled. Maybe you're using a really old build, like, from yesterday or something :) Currently there isn't any flickering when this is happening, so that just leaves the 2 second delay. The only game for which this is an issue, that I know of, is Dragon Warrior I&II. Maybe I'll make something similar to TempGBA's game_config.txt for things like this.

Stewmath commented 11 years ago

Donkey Kong Land 2's border is fixed. If there's anything else you can open up another issue.