Stewmath / oracles-disasm

Disassembly of Oracle of Ages and Seasons
171 stars 42 forks source link

Error compiling vanilla ROMs #20

Closed Zixiken closed 5 months ago

Zixiken commented 1 year ago

When I set the Makefile to BUILD_VANILLA=true, I get the following error:

MEM_INSERT: Origin ($4000) overflows from bank (1). ^ code/ages/garbage/bank01End.s:17: Writing a byte

I'm using your fork of wla-dx, with the emptyfill-banknumber branch, and I've tried it with cmake build types release and debug to see if it made a difference, but there was no change. The build completes when not doing a vanilla build, but then the randomizer doesn't detect them as vanilla.

OS: Gentoo Linux Cmake: 3.24.3 Make: 4.3 GCC: 12.2.1

Stewmath commented 1 year ago

You could try wiping your build directories? (rm -R build_ages_v for "vanilla" builds)

Sometimes this can help with weird issues like that. While I haven't been using that branch much, rather using wla-dx v9.11, it should be the same thing (and I did test it just now and it seems to work).

Zixiken commented 1 year ago

I ran make clean and confirmed the build directories were deleted. I was on that branch since readme.md linked to it, but I gave wla-dx v9.11 a try and had the same error.

Stewmath commented 1 year ago

I would add that the "MEM_INSERT" messages usually don't prevent the ROM from assembling, but they can be indicative of a problem. Perhaps you could do a binary diff on the resulting ROM and a ROM which you know which is clean to see what differences there are.

Zixiken commented 1 year ago

Hmm, this one definitely looks like an error and not a warning, there's no ages rom created. Here's the "full" output of make, run with all the previous build artifacts still there:

=====Ages=====
wla-gb -o build/ages.o -DBUILD_VANILLA -D ROM_AGES ages.s
MEM_INSERT: Origin ($4000) overflows from bank (1).
   ^ code/ages/garbage/bank01End.s:17: Writing a byte
make[2]: *** [Makefile:143: build/ages.o] Error 1
make[1]: *** [Makefile:116: ages] Error 2
make: *** [Makefile:107: all] Error 2

And there's no build/ages.o file. Not sure if it makes a difference, but I'm on the rando/ng branch since that's where the git submodule in the oracles-randomizer-ng repo is pointing.

Stewmath commented 1 year ago

That does make a fairly big difference, but I'm not getting that error on that branch either.

Just to be sure we're on the same page here, could you share the commit hashes for both wla-dx and oracles-disasm?

Stewmath commented 5 months ago

Closing due to inactivity.