search

Stewori / JyNI

Enables Jython to load native CPython extensions.
https://jyni.12hp.de
Other
152 stars 17 forks source link

Bugfix for macOS 10.13 #19

Closed peanut256 closed 7 years ago

peanut256 commented 7 years ago

Fixed bug in demo scripts caused by missing macOS revision number

Stewori commented 7 years ago

Thanks for spotting this! I'm a bit surprised that the approach with rfind('.') stopped working. Did they change their version string format? Do they have kind of nano-version number now?

peanut256 commented 7 years ago

It looks like new minor versions just omit the revision number, i.e. 10.12 instead of 10.12.0. If you'd like a more adaptive approach than taking the first five characters, you could use a regex like ^([0-9]+.[0-9]+)

Stewori commented 7 years ago

Alright, I see. Thanks for the fix. I think, the simple version is sufficient.