= isPlaying ? 'Pause' : 'Play'; is buggy

SthephanShinkufag / bytebeat-composer

Bytebeat player with a collection of many formulas from around the internet.

https://dollchan.net/bytebeat/

MIT License

85 stars 26 forks source link

= isPlaying ? 'Pause' : 'Play'; is buggy #21

Closed 21436587 closed 2 years ago

21436587 commented 2 years ago

411 togglePlay(isPlaying, isSendData = true) {
412     this.controlTogglePlay.title = isPlaying ? 'Pause' : 'Play';  << this causes error
413     this.controlTogglePlay.classList.toggle('control-play=', !isPlaying);

In https://21436587.github.io/tier2_bytebeat/ , this string causes error, as Uncaught TypeError: Cannot set properties of null (setting 'title') Do my web has errors? Please let me know.

SArpnt commented 2 years ago

this is an issue with your website, not dollchan. you incorrectly merged commits.
i don't think this is the place to ask for get coding advice