search

SthephanShinkufag / bytebeat-composer

Bytebeat player with a collection of many formulas from around the internet.
https://dollchan.net/bytebeat/
MIT License
87 stars 26 forks source link

semantic elements #24

Open SArpnt opened 2 years ago

SArpnt commented 2 years ago

minor complaint but using the details tag would improve accessibility and not need supporting javascript code already implemented on my website, not entirely sure how styling works for this but i don't think it would be difficult

SArpnt commented 2 years ago

i think this issue should be extended to more elements actually, for example many buttons on the website are divs, which makes them impossible to select with tab (the library buttons seem to have selectable text too), the time counter is a text input and not a number input, and you could probably use some elements like main, aside, article, section, footer, etc.

SArpnt commented 2 years ago

i think the library should use list elements and the info section use paragraphs instead of line breaks

there should also be an aria-label on the code editor and oscilloscope