SthephanShinkufag / bytebeat-composer

Bytebeat player with a collection of many formulas from around the internet.
https://dollchan.net/bytebeat/
MIT License
90 stars 28 forks source link

many playlist issues #7

Closed SArpnt closed 2 years ago

SArpnt commented 3 years ago

i keep noticing a lot of playlist issues, it's difficult to remember them all but the most recent ones i've seen are with No Limit

No Limit non-sine version links to a post by ryg that uses sine and doesn't match the code, it's not clear where the code comes from. rygs username is also capitalized, which as far as i can tell is incorrect.

No Limit added recently isn't the original, it's some other modified version that still doesn't use sine, and it's not clear where this is from either.

the original No Limit and rygs optimizations are nowhere in the playlist.

i've seen many other issues, such as:

where does the name No Limit even come from? i feel like we should have some wiki to keep track of the history of bytebeats, the pouet forms are already filled with dead links and it's not clear what information will be lost. (it would also be extremely convenient to have since the library could be generated from it)

i think at some point both of us should go through both of the playlists and try and fix everything, and add some system for leaving notes for when the history, versions, original posts, and authors of a song can't be found.

SArpnt commented 3 years ago

the code for constructivist doesn't match the post

SthephanShinkufag commented 3 years ago

where does the name No Limit even come from?

It's an imitation of 90's song called No Limit. https://www.youtube.com/watch?v=qM5W7Xn7FiA

No Limit added recently

No Limit not added recently.

https://github.com/SthephanShinkufag/bytebeat-composer/commit/85595e1598b60a392daa34bdfbaf2075b0ff6553#diff-0eb547304658805aad788d320f10bf1f292797b5e6d745a3bf617584da017051R446 https://github.com/SthephanShinkufag/bytebeat-composer/commit/3ce7fccb008e12bd860f123c2a81d7e77a4d66df#diff-0eb547304658805aad788d320f10bf1f292797b5e6d745a3bf617584da017051R575 (under load diff link for index.html)

I don't remember where I took these optimized versions. The first code was in my text file collection a years ago before github repo.

SthephanShinkufag commented 3 years ago

the code for constructivist doesn't match the post

Yes, I added some multipliers for volume, because the original was very quiet, don't hear anything.

SthephanShinkufag commented 3 years ago

Also I optimized A LOT of songs. Almost 70% of songs are optimized anyway if you look closely. Removed unnecessary parentheses, and the like.

SthephanShinkufag commented 3 years ago

Oh, I remembered. Initially I collected only non-js formulas with one t variable, to simulate on AVR microcontroller. Then I collected formulas including js code, but avoided the code where there is a sine because I considered the built-in sine generators "not true". So I found a version without sine somewhere. I don't remember exactly, maybe I even modified it myself, that was a long time ago.

SthephanShinkufag commented 3 years ago

rygs username is also capitalized, which as far as i can tell is incorrect

I have an innate hatred for texts that start with a small letter. This applies to comments and other things. Initially, all nicknames in the list began with a capital letter, but now I realized that it was wrong.

SthephanShinkufag commented 3 years ago

Fixed small letter nicknames, added missing urls, updating descriptions from original posts. Added original signed mode "No Limit" songs by mu6k and ryg. Also added "G minor Bach" original cos-version, also in signed mode. Yehar's "No 5" swithced to signed mode, as I remember I heared exactly that sound at http://wurstcaptures.untergrund.net/music/