search

Sti3bas / laravel-scout-array-driver

Array driver for Laravel Scout
MIT License
89 stars 8 forks source link

Laravel 11 Support #17

Closed sweptsquash closed 9 months ago

sweptsquash commented 9 months ago

This PR introduces support for Laravel 11. I've also updated Github Actions workflow to test against Laravel 9, 10 and 11 on PHP 8.0, 8.1, 8.2 and 8.3.

Linted with Laravel Pint.

sweptsquash commented 9 months ago

@Sti3bas would be good to get your thoughts when you get a moment 😊

Sti3bas commented 9 months ago

@sweptsquash can you please check why P8.1 - L9.* - prefer-lowest is failing?

sweptsquash commented 9 months ago

@sweptsquash can you please check why P8.1 - L9.* - prefer-lowest is failing?

Sure thing. Looks like this test might be one that occasionally fails as it passed on my branch

sweptsquash commented 9 months ago

@Sti3bas tests should now pass 😊 thank your for the feedback and taking the time to review this PR.

Sti3bas commented 9 months ago

@sweptsquash hmm, strange, it still fails on master branch.

sweptsquash commented 9 months ago

@sweptsquash hmm, strange, it still fails on master branch.

@Sti3bas I managed to find the issue that was causing this and it was an oversight on my part, made a PR for it https://github.com/Sti3bas/laravel-scout-array-driver/pull/18

Sti3bas commented 9 months ago

@sweptsquash released in https://github.com/Sti3bas/laravel-scout-array-driver/releases/tag/v4.0

Thank you very much for your contribution and help!