search

Stichting-MINIX-Research-Foundation / minix

Official MINIX sources - Automatically replicated from gerrit.minix3.org
Other
2.99k stars 969 forks source link

Compiling 'binstall/xinstall.lo' issue #336

Closed nazebzurati closed 1 year ago

nazebzurati commented 1 year ago

Step to reproduce:

Machine:

Notes:

Attachments:

nazebzurati commented 1 year ago

I believe that this is due to repo's ./sys/sys/stat.h is not used when cross compiling and build platform's sys/stat.h was used instead. 

...
xinstall.o: /usr/include/x86_64-linux-gnu/sys/stat.h
...

As attached is the ./../tools/binstall/xinstall.d file produced when cross compiling: xinstall.d

petershh commented 1 year ago

first of all, there's nbsed build failure. Are there any error message. You may want to redirect stderr to log as well.

nazebzurati commented 1 year ago

The log.txt I attached get from command ./releasetools/x86_cdimage.sh 2>&1 | tee log.txt. Please suggest the suitable command as I believe 2>&1 have already include both stdout and stderr.

petershh commented 1 year ago

I've installed fresh Ubuntu 22.04.01 in WSL, cloned minix repository and appliet patch suite from #322 . Build seems like to work.

nazebzurati commented 1 year ago

The mentioned issue was fixed.

The steps are as follows:

  1. Clone the repo or git hard reset and clean.
  2. Download #322 patch: curl https://github.com/petershh/minix/commit/75e1abafd68c2eb6ded0d311facd918a7e0b8517.patch -o patch.txt
  3. Apply patch: git apply --ignore-space-change --ignore-whitespace patch.txt
  4. Add string header as per this patch manually.
  5. Run x86_cdimage.sh script and redirect the output to log: ./releasetools/x86_cdimage.sh 2>&1 | tee log.txt
  6. Let it compile!

If any of these steps is not expected, please let me know. Else, I'll close this issue soon. Thanks for your verification and assistant!