Stichting-MINIX-Research-Foundation / minix

Official MINIX sources - Automatically replicated from gerrit.minix3.org
Other
2.9k stars 946 forks source link

KEY_MAGIC should be changed #338

Open ghost opened 1 year ago

ghost commented 1 year ago

You removed the compression of keymap binary files. The format of the binary file has been changed, but not the magic identifier: https://github.com/Stichting-MINIX-Research-Foundation/minix/blob/4db99f4012570a577414fe2a43697b2f239b699e/minix/include/minix/keymap.h#L167

The original one was KMAP and it was renamed to KMAZ when the compression was implemented. Now you have removed the compression, but not the magic key. I do not know if it is still the same as the original implementation (Minix 386vm). May be KMA330 would be a suitable magic key.