search

Sticktron / DarkMessages

Dark Mode for the Messages App (iOS 10)
21 stars 7 forks source link

Control with NightShift toggle doesn't respect NightShift state #31

Closed thefowles1 closed 7 years ago

thefowles1 commented 7 years ago

As of 1.1.3 beta 4, the toggle for allowing the tweak to be automatically controlled by NightShift does not respect the state of NightShift and instead keeps the tweak enabled 24/7. This didn't occur with 1.1.2. Observe the GIF below showing that NightShift is off (I have it set for sunrise/sunset), yet the dark mode toggle stays enabled and re-enables with the NightShift toggle on.

img_0458

Sticktron commented 7 years ago

are you using Yalu1011 on an iPhone 7?

Sticktron commented 7 years ago

This should be working now as of 1.1.3~b5

thefowles1 commented 7 years ago

I am using Yalu102 b7 on an iPhone SE. I will try the update in a little while and report back. Thank you for your continuous communication and effort.

thefowles1 commented 7 years ago

Updated to 1.1.3 beta5-1 and it still doesn't respect the NightShift state on my device. It does ask to restart the messages app, and it properly minimizes the app in preparation for restarting it, but when opening the app immediately after, it appears dark themed for a moment (like it hadn't been released from memory yet) and then crashes. After, it remains dark themed even with NightShift turned off.

pleasantnastyhochstettersfrog-size_restricted

Sticktron commented 7 years ago

Damn. I had hoped that moving the night shift detection to SpringBoard instead of backboard would solve the issue :(

I'm afraid there is nothing else I can do at this point. I don't have an iPhone 7 or any device on yalu1011 to test with.

thefowles1 commented 7 years ago

I don't use either of those; I'm on an iPhone SE on 10.2.

It worked before, in version 1.1.2. Did anything about the toggle respect change?

Sticktron commented 7 years ago

Oh ok, that's interesting. I thought this was related to yalu1011.

Yes there was a change from 1.1.2 - 1.1.3, and then another change in 1.1.3b5. So it worked for you originally eh?

Would you be interested in helping me test a debug version? Are you able to use deviceconsole, Xcode, or some other way to see the logging information in realtime?

thefowles1 commented 7 years ago

I, uh, have no idea what any of those are. I'm a novice at best when it comes to tweak development/debugging so I wouldn't count on me for that if I were you. Yes, it did work for me originally. But I will test for you if you'd like.

Sticktron commented 7 years ago

That's ok :). I'll see what I can do from here.