Closed StijnArts closed 1 month ago
could you send me the schematic?
Sure! Also, Ive noticed that it only seems to happen when it places a cobblestone generator. Maybe its because the placed block doesnt have an enum assigned to it? Though I cant say for sure.
Honestly any schematic which places a cobblestone generator seems to cause a crash, but I can send you the schematic later today
From: Mr Sticky Piston @.> Sent: Sunday, June 23, 2024 2:53:25 PM To: StickyPiston-development/CreateCobblestone @.> Cc: Stijn Arts (student) @.>; Author @.> Subject: Re: [StickyPiston-development/CreateCobblestone] Placing a generator using a schematticannon crashes a server. (Issue #3)
could you send me the schematic?
— Reply to this email directly, view it on GitHubhttps://github.com/StickyPiston-development/CreateCobblestone/issues/3#issuecomment-2184977768, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWOC6RZCIEX35MKXNZWN6GDZI3AMLAVCNFSM6AAAAABJTVWYR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBUHE3TONZWHA. You are receiving this because you authored the thread.Message ID: @.***>
You mean it doesnt crash with the other generators? Also, can you try if you can replicate it on the latest version?
Ive had this bug on 1.2.0, has it been updated since? And yeah I don't think it crashes with the other ones
Get Outlook for Androidhttps://aka.ms/AAb9ysg
From: Mr Sticky Piston @.> Sent: Sunday, June 23, 2024 6:32:45 PM To: StickyPiston-development/CreateCobblestone @.> Cc: Stijn Arts (student) @.>; Author @.> Subject: Re: [StickyPiston-development/CreateCobblestone] Placing a generator using a schematticannon crashes a server. (Issue #3)
You mean it doesnt crash with the other generators? Also, can you try if you can replicate it on the latest version?
— Reply to this email directly, view it on GitHubhttps://github.com/StickyPiston-development/CreateCobblestone/issues/3#issuecomment-2185145509, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWOC6R5O7KOCK25NTELWDDLZI32C3AVCNFSM6AAAAABJTVWYR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBVGE2DKNJQHE. You are receiving this because you authored the thread.Message ID: @.***>
Yes, 1.3 just came out and has a lot of backend changes, including forge support. Could you please remove the outlook ad?
I found the issue.
Create schematicannon places a fully nbt-less block, while the standard block always stores the type at default.
this is the code for readin the data:
@Override
protected void read(CompoundTag compound, boolean clientPacket) {
super.read(compound, clientPacket);
//CreateCobblestoneMod.LOGGER.error("Reading: " + compound.getAsString());
this.type = GeneratorType.valueOf(compound.getString("type"));
}
with no data existing, it tries to parse "GeneratorType. "
I will probally fix this in a few days, because will be fairly busy.
got it working, needs some testing too. test build can be downloaded at the actions: https://github.com/StickyPiston-development/CreateCobblestone/actions/runs/9635484906 https://github.com/StickyPiston-development/CreateCobblestone/assets/97804691/6824286f-b703-4424-93dc-d8f0ea83a943
Thank you! Ill test it out tomorrow
Get Outlook for Androidhttps://aka.ms/AAb9ysg
From: Mr Sticky Piston @.> Sent: Sunday, June 23, 2024 8:14:29 PM To: StickyPiston-development/CreateCobblestone @.> Cc: Stijn Arts (student) @.>; Author @.> Subject: Re: [StickyPiston-development/CreateCobblestone] Placing a generator using a schematticannon crashes a server. (Issue #3)
got it working, needs some testing too. test build can be downloaded at the actions: https://github.com/StickyPiston-development/CreateCobblestone/actions/runs/9635484906 https://github.com/StickyPiston-development/CreateCobblestone/assets/97804691/6824286f-b703-4424-93dc-d8f0ea83a943
— Reply to this email directly, view it on GitHubhttps://github.com/StickyPiston-development/CreateCobblestone/issues/3#issuecomment-2185259126, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWOC6R7LAZMO7KJKN57S6H3ZI4GALAVCNFSM6AAAAABJTVWYR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBVGI2TSMJSGY. You are receiving this because you authored the thread.Message ID: @.***>
Here you go! (for forge, neoforge, fabric and quilt. https://modrinth.com/mod/create-cobblestone/version/1.3.1+forge-1.20.1-36 https://modrinth.com/mod/create-cobblestone/version/1.3.1+fabric-1.20.1-36
Placing a generator using a schematticannon crashes a server.
net.minecraft.class_148: Ticking block entity at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:901) ~[server-intermediary.jar:?] at net.minecraft.class_3176.method_3813(class_3176.java:283) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:824) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.handler$bng000$carpet$modifiedRunLoop(MinecraftServer.java:19442) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:650) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:265) ~[server-intermediary.jar:?] at java.lang.Thread.run(Thread.java:1583) ~[?:?] Caused by: java.lang.IllegalArgumentException: No enum constant net.createcobblestone.util.GeneratorType. at java.lang.Enum.valueOf(Enum.java:293) ~[?:?] at net.createcobblestone.util.GeneratorType.valueOf(GeneratorType.java:14) ~[createcobblestone-1.2.0+fabric-1.20.1-22.jar:?] at net.createcobblestone.blocks.CobblestoneGeneratorBlockEntity.read(CobblestoneGeneratorBlockEntity.java:50) ~[createcobblestone-1.2.0+fabric-1.20.1-22.jar:?] at com.simibubi.create.foundation.blockEntity.SmartBlockEntity.method_11014(SmartBlockEntity.java:119) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?] at com.simibubi.create.foundation.utility.BlockHelper.placeSchematicBlock(BlockHelper.java:306) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?] at com.simibubi.create.content.schematics.cannon.LaunchedItem$ForBlockState.place(LaunchedItem.java:129) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?] at com.simibubi.create.content.schematics.cannon.LaunchedItem.update(LaunchedItem.java:63) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?] at com.simibubi.create.content.schematics.cannon.SchematicannonBlockEntity.tickFlyingBlocks(SchematicannonBlockEntity.java:641) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?] at com.simibubi.create.content.schematics.cannon.SchematicannonBlockEntity.tick(SchematicannonBlockEntity.java:281) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?] at com.simibubi.create.foundation.blockEntity.SmartBlockEntityTicker.tick(SmartBlockEntityTicker.java:15) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?] at net.minecraft.class_2818$class_5563.redirect$bnj000$carpet$checkProcessBEs(class_2818.java:790) ~[server-intermediary.jar:?] at net.minecraft.class_2818$class_5563.method_31703(class_2818.java:662) ~[server-intermediary.jar:?] at net.minecraft.class_2818$class_5564.method_31703(class_2818.java:716) ~[server-intermediary.jar:?] at net.minecraft.class_1937.method_18471(class_1937.java:470) ~[server-intermediary.jar:?] at net.minecraft.class_3218.method_18765(class_3218.java:390) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:897) ~[server-intermediary.jar:?] ... 6 more