Stieneee / mumble-discord-bridge

A simple voice bridge between Mumble and Discord.
MIT License
153 stars 16 forks source link

Audio from Discord web client users is not be processed correctly #22

Closed Stieneee closed 3 years ago

namtsui commented 3 years ago

Yeah I see this bug, too. I wanted to test using linux as a sanity check.

android discord + linux bridge/mumble/murmurd: OK both ways web client discord + linux bridge/mumble/murmurd: mumble --> discord OK. discord --> mumble no audio and throws the same errors about

2021/05/03 09:27:13 dgVoice: Error decoding opus data: invalid packet
2021/05/03 09:27:13 dgVoice: Error decoding opus data: buffer is too small
2021/05/03 09:27:13 dgVoice: Error decoding opus data: buffer is too small
2021/05/03 09:27:13 dgVoice: Error decoding opus data: buffer is too small
2021/05/03 09:27:13 dgVoice: Error decoding opus data: invalid packet
2021/05/03 09:27:13 dgVoice: Error decoding opus data: invalid packet
2021/05/03 09:27:13 dgVoice: Error decoding opus data: buffer is too small
2021/05/03 09:27:13 dgVoice: Error decoding opus data: buffer is too small
2021/05/03 09:27:13 dgVoice: Error decoding opus data: buffer is too small
2021/05/03 09:27:13 dgVoice: Error decoding opus data: invalid packet
2021/05/03 09:27:13 Opus size error
2021/05/03 09:27:13 dgVoice: Error decoding opus data: invalid packet
2021/05/03 09:27:13 Opus size error
2021/05/03 09:27:13 dgVoice: Error decoding opus data: buffer is too small
2021/05/03 09:27:13 Opus size error
2021/05/03 09:27:13 dgVoice: Error decoding opus data: invalid packet

web client discord + openbsd bridge/mumble/umurmurd: same errors but eventually segfaults. see: https://github.com/Stieneee/mumble-discord-bridge/issues/20#issuecomment-831109608

Stieneee commented 3 years ago

After some digging this appears to be the fix.

https://github.com/bwmarrin/discordgo/commit/b18e1d72763cc67f7be5418b3be2471d7349afb0#diff-74522acf0f17ab66145d5d550513c9167dc20f264f49712f4913ab611074cde1