Stieneee / mumble-discord-bridge

A simple voice bridge between Mumble and Discord.
MIT License
153 stars 16 forks source link

discordgo needs updating. voice stopped working. #45

Closed namtsui closed 1 year ago

namtsui commented 1 year ago

the bridge stopped connecting. I observe the bot joining the discord channel but never connecting to mumble. The log keeps retrying: 2023/03/24 23:10:07 Users detected in mumble and discord, bridging

discordgo might need to be updated, as noted here: https://github.com/bwmarrin/discordgo/issues/1346

namtsui commented 1 year ago

updating to discordgo v0.24.1 seems to have resolved the issue. I have not been able to test sound but at least now the bridge connects to discord and mumble.

see: https://github.com/bwmarrin/discordgo/releases/tag/v0.24.1 https://github.com/bwmarrin/discordgo/commit/9910ae2c753f90a32a5845d1923b5ceadf5832e6

diff /home/namtsui/workspace/mumble-discord-bridge
commit - 97904d3e88d20f514d94830f822c58c435f2151a
path + /home/namtsui/workspace/mumble-discord-bridge
blob - d8a41c81d0664c65b9053d6cb754150a63d3a08c
file + go.mod
--- go.mod
+++ go.mod
@@ -3,7 +3,7 @@ require (
 go 1.15

 require (
-       github.com/bwmarrin/discordgo v0.24.0
+       github.com/bwmarrin/discordgo v0.24.1
        github.com/joho/godotenv v1.4.0
        github.com/prometheus/client_golang v1.12.1
        github.com/stieneee/gopus v0.0.0-20210424193312-6d10f6090335
blob - 28cc32bfd13791f8972b67709650bb882d352fcf
file + go.sum
--- go.sum
+++ go.sum
@@ -42,8 +42,8 @@ github.com/bwmarrin/discordgo v0.24.0 h1:Gw4MYxqHdvhO9
 github.com/beorn7/perks v1.0.0/go.mod h1:KWe93zE9D1o94FZ5RNwFwVgaQK1VOXiVxmqh+CedLV8=
 github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=
 github.com/beorn7/perks v1.0.1/go.mod h1:G2ZrVWU2WbWT9wwq4/hrbKbnv/1ERSJQ0ibhJ6rlkpw=
-github.com/bwmarrin/discordgo v0.24.0 h1:Gw4MYxqHdvhO99A3nXnSLy97z5pmIKHZVJ1JY5ZDPqY=
-github.com/bwmarrin/discordgo v0.24.0/go.mod h1:NJZpH+1AfhIcyQsPeuBKsUtYrRnjkyu0kIVMCHkZtRY=
+github.com/bwmarrin/discordgo v0.24.1 h1:XNdU5ZvPFH3r39y/pRUBfzH6d5njKAiRASypBws0lkU=
+github.com/bwmarrin/discordgo v0.24.1/go.mod h1:NJZpH+1AfhIcyQsPeuBKsUtYrRnjkyu0kIVMCHkZtRY=
 github.com/census-instrumentation/opencensus-proto v0.2.1/go.mod h1:f6KPmirojxKA12rnyqOA5BBL4O983OfeGPqjHWSTneU=
 github.com/cespare/xxhash/v2 v2.1.1/go.mod h1:VGX0DQ3Q6kWi7AoAeZDth3/j3BFtOZR5XLFGgcrjCOs=
 github.com/cespare/xxhash/v2 v2.1.2 h1:YRXhKfTDauu4ajMg1TPgFO5jnlC2HCbmLXMcTG5cbYE=
rhetr commented 1 year ago

sound works for me using discordgo v0.24.1

namtsui commented 1 year ago

yeah it unbreaks it in my testing, too

MaxWaldorf commented 1 year ago

A package was republished here while the author correct his repo... https://github.com/BenchmarkSims/mumble-discord-bridge/pkgs/container/mumble-discord-bridge

MaxWaldorf commented 1 year ago

updated with PR #47