Runtime modes, status announcements, discord control

Stieneee / mumble-discord-bridge

A simple voice bridge between Mumble and Discord.

MIT License

153 stars 16 forks source link

Runtime modes, status announcements, discord control #7

Closed stryan closed 3 years ago

stryan commented 3 years ago

As mentioned in #6, here's the big PR with roughly the following feature list:

Three separate runtime modes: constant (as it is now), manual, and automatic startup
Discord bot shows number of users in mumble as status
Control the bridge through Discord
Announcements in Mumble when user joins Discord
Auto-join specific Mumble channel

Stieneee commented 3 years ago

Everything looks good.

Last night I tried it out and it behaved as expected. I noticed CPU load was high and found a sneaky default case in the mumble onAudioStream event handler. I will apply my patch after I merge.

I believe the default mode should be constant or automatic as I believe many people will struggle to figure out why the bridge is not working without clear instruction. I believe having it work out of the box is better than having to provide instruction.

stryan commented 3 years ago

Ah, good catch, I saw pull-7.

But sure, that makes sense. I've already got another PR incoming that uses some of your feedback from the initial issue and fixes some of the announcement code. It's much smaller then this one so I'll just sneak the default modeset in there. To keep continuity with how the original code worked I'll set constant as the default.

EDIT: ignore that, I see your commits already.