Stieneee / mumble-discord-bridge

A simple voice bridge between Mumble and Discord.
MIT License
153 stars 16 forks source link

swap GuildCreate and Ready, fix auto-mode #9

Closed stryan closed 3 years ago

stryan commented 3 years ago

This PR swaps the GUILDCREATE and READY discord event handlers; it turns out when I initially wrote it on my end I got the two event types confused. The READY event does NOT contain initial voice state information, so initial setup hasn't been working this whole time. I fixed this in one of my own branches but was still testing some other stuff.

I also re-added the user count for Mumble. This is populated by a MumblePing as opposed to the mumbleUsers map, which only contains data when the bridge is actively connected to mumble. Without that auto-mode didn't work since the bridge never saw anyone connect to Mumble. This also meant I re-closed the Die channel since otherwise the bridge was failing to clean up properly and would also segfault.

If you were in the middle of doing something regarding the mumble/die chan stuff I can drop that commit. Mostly wanted to merge the discord change since that was my bad and actively doing the wrong behaviour.

Stieneee commented 3 years ago

looks good to me.