search

Stiffstream / restinio

Cross-platform, efficient, customizable, and robust asynchronous HTTP(S)/WebSocket server C++ library with the right balance between performance and ease of use
Other
1.15k stars 93 forks source link

An overload of server_settings_t::address that accepts asio::ip::address #100

Closed eao197 closed 3 years ago

eao197 commented 4 years ago

At this moment there are only overloads of server_settings_t::address() for std::string as parameters. There should also be overloads of address() method that accept asio::ip::address.

eao197 commented 4 years ago

The main problem with this issue is the fact that address is stored in server_settings_t as a string. And then it is handled as a string in acceptor_t. It's required to transform server_settings_t::m_address into optional_t<asio::ip::address> and move handling of string-to-address conversion from acceptor_t into server_settings_t.

eao197 commented 3 years ago

Fixed in v.0.6.11.