search

Stiffstream / restinio

Cross-platform, efficient, customizable, and robust asynchronous HTTP(S)/WebSocket server C++ library with the right balance between performance and ease of use
Other
1.15k stars 93 forks source link

fmt 8.0.1 format string must be contexpr #153

Closed bigerl closed 2 years ago

bigerl commented 2 years ago

I ran into an issue when building an application with restinio and fmt 8.0.1.

The problem is that in version 8.0.1 fmt requires the format string to be constexpr.

I had a short look and fixed it.

eao197 commented 2 years ago

Hi!

Which compiler and C++ standard do you use?

bigerl commented 2 years ago

I used clang-12 and C++20 on a x86-64 linux machine with libstdc++ 11 (from g++-11)

eao197 commented 2 years ago

Ok, thanks. I'll take a closer look tomorrow.

eao197 commented 2 years ago

I've fixed that issue a bit differently. However, there are warnings about the use of fmt::format_to that was deprecated in v.8.0.0. I'll address them at the beginning of the next week. After that, the updated version of RESTinio will be released.

bigerl commented 2 years ago

I must admit I forgot to dig deeper before I created the PR. Your solution looks very well thought out. Thanks for your quick reply and action.

bigerl commented 2 years ago

Better solution at 0.6-dev-issue-153