search

Stiffstream / restinio

Cross-platform, efficient, customizable, and robust asynchronous HTTP(S)/WebSocket server C++ library with the right balance between performance and ease of use
Other
1.13k stars 92 forks source link

[idea] Deprecation of RESTINIO_FIND_DEPS in favor of RESTINIO_EXTERNAL_FMT, RESTINIO_EXTERNAL_CATCH2 and so on #160

Closed eao197 closed 8 months ago

eao197 commented 2 years ago

Dependency management in CMake scripts started from very simple things but evolved to rather complex scheme that I don't understand fully. Now we have RESTINIO_FIND_DEPS with additional case RESTINIO_USE_EXTERNAL_HTTP_PARSER (and I don't get an idea of RESTINIO_FIND_DEPS=ON and RESTINIO_USE_EXTERNAL_HTTP_PARSER=OFF case) plus RESTINIO_USEEXTERNAL*_LITE options.

Maybe it's better to remove RESTINIO_FIND_DEPS and use new options like RESTINIO_USE_EXTERNAL_FMT, RESTINIO_USE_EXTERNAL_HTTP_PARSER (+RESTINIO_USE_EXTERNAL_UNOFFICIAL_HTTP_PARSER), RESTINIO_USE_EXTERNAL_CATCH2 and other.

I think that change should lead to change a version number, e.g. 0.7.0 instead of 0.6.15. And that version change can be done during adopting to Catch2 v3.

v3 of Catch2 is no more single-header header-only library and switching to v3 may require some refactoring of RESTinio's test. It's a significant change to be reflected in RESTinio's version bump.

eao197 commented 8 months ago

This issue is no more actual since v.0.7.0.